commonsrdf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ansell <...@git.apache.org>
Subject [GitHub] incubator-commonsrdf pull request #27: COMMONSRDF-47 RDFSyntax as an interfa...
Date Thu, 17 Nov 2016 22:55:05 GMT
Github user ansell commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/27#discussion_r88350010
  
    --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
    @@ -34,7 +152,7 @@
      *      1.1 Primer</a>
      * @see org.apache.commons.rdf.experimental.RDFParser
      */
    -public enum RDFSyntax {
    +  public enum OfficialRDFSyntax implements RDFSyntax {
    --- End diff --
    
    Also, relocating this to its own class would be ideal IMO for maintainability separate
from the base interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message