commonsrdf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ansell <...@git.apache.org>
Subject [GitHub] incubator-commonsrdf pull request #27: COMMONSRDF-47 RDFSyntax as an interfa...
Date Thu, 17 Nov 2016 22:55:02 GMT
Github user ansell commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/27#discussion_r88565106
  
    --- Diff: simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
    @@ -240,7 +240,7 @@ public T rdfTermFactory(RDF rdfTermFactory) {
         public T contentType(RDFSyntax rdfSyntax) throws IllegalArgumentException {
             AbstractRDFParser<T> c = clone();
             c.contentTypeSyntax = Optional.ofNullable(rdfSyntax);
    -        c.contentType = c.contentTypeSyntax.map(syntax -> syntax.mediaType);
    +        c.contentType = c.contentTypeSyntax.map(syntax -> syntax.mediaType());
             return c.asT();
    --- End diff --
    
    It hurts my head thinking about this, but what is the signature for the generic type "T"
designed to do. It seems like a circular definition, which doesn't really make sense but I
can't think why T could have been introduced so I am stuck at seeing it as circular.
    
    ```
    AbstractRDFParser<T extends AbstractRDFParser<T>>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message