From dev-return-169353-archive-asf-public=cust-asf.ponee.io@commons.apache.org Fri Jan 4 19:04:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A46E180660 for ; Fri, 4 Jan 2019 19:04:26 +0100 (CET) Received: (qmail 60249 invoked by uid 500); 4 Jan 2019 18:04:25 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 60236 invoked by uid 99); 4 Jan 2019 18:04:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jan 2019 18:04:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 161B2C5C65 for ; Fri, 4 Jan 2019 18:04:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.547 X-Spam-Level: *** X-Spam-Status: No, score=3.547 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N1i8wL4MgJL4 for ; Fri, 4 Jan 2019 18:04:21 +0000 (UTC) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D95E35F3D0 for ; Fri, 4 Jan 2019 18:04:20 +0000 (UTC) Received: by mail-it1-f196.google.com with SMTP id a6so2547417itl.4 for ; Fri, 04 Jan 2019 10:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=czPF0eTlBSRkawHNqcSlTLZeNA3BZ6OdMn2v0jt2s4o=; b=IWwTKRQ2BrT/C7SE4+q3OGmw2EpZGfjtxA8HDEmmGV9vCFoy7d7IPRxFaxGUbWIiTC sTZMJtM4Nl2lXjthNz0ZJ2Q9dBNqTte1f2K64NS20zEQhCdMt1Yyij9uCEEUB3zrUAmr N4FkJV7VN60UNCeHBpxJ+rSXCgCA4gnRJPd8b5Xj1JYwIfzwqgG9+7QCH1Kbxw5V8EIt Ys/4VhDviIcsJZa471rzr2DW6KyX38m1pyrkihvAObtiXU4ixwurn4ZY2oIBq1Oy9N1C E7knOu87gJuvIghMDVEBRnq3pXJNuh6CvLmWh4ZnzOPFe8OYrZyMemYjXnIX6fqHaicA xovA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=czPF0eTlBSRkawHNqcSlTLZeNA3BZ6OdMn2v0jt2s4o=; b=EF8QCu2yxto6MOhEqwGX60g5h7Fl3TvIpigFHkwEsNfJg5s/n+EsdZ0mzsIPna/X0H z504ka5l34j1cBN5r34jQNykgJmFaIC3ZpxvuH5ruz2eUpBWlk1LOmJZVSj9PkgIE5Mf Sn9Am2Xh59TjGR4VFwxEuWd7koOftQQdiNHc/jxtj0YePtDYXHXoVpMCR2NUEVo9AyTC g8QbLtYHnN5bf/ihGNgrUp5jY1t9qaNgy3UmAZYFt9qWAxhMvc5scMuYyjMln/w+0Gdc 2RCVsl9HV3M467YGaAyL2ZhWvnU9asBdQZMz2rInsYmzWDu3zPYlAXH5Gt+bkLz3YiE4 qNtg== X-Gm-Message-State: AJcUukdNrfPDSIpjPlsR0tAg/BgbwZnvq4iaaiiJAv3mJWS/yfj+rLlM EzU9J4OCMdSOl7gH3UNIV4L4gGEJiv+yBGwiGX6Trw== X-Google-Smtp-Source: ALg8bN66SnQFOv7YAPUp58wLO6pM2XK2bSbZdqEVgr8FF5vWWSuJcBGbag7rb0506nPxYA9Fbp3rIdHq5HyCIdodw5o= X-Received: by 2002:a24:4507:: with SMTP id y7mr1601217ita.134.1546625059937; Fri, 04 Jan 2019 10:04:19 -0800 (PST) MIME-Version: 1.0 References: <613799745.9475559.1545862791696@mail.yahoo.com> <4d332d6fc8ea90d886434deeb1d883ca@scarlet.be> <5ea8cdb2e8d48da6edf4f26a7f672368@scarlet.be> In-Reply-To: <5ea8cdb2e8d48da6edf4f26a7f672368@scarlet.be> From: Amey Jadiye Date: Fri, 4 Jan 2019 23:34:07 +0530 Message-ID: Subject: Re: [VOTE][RC2] Commons collections 4.3 To: Commons Developers List Content-Type: multipart/alternative; boundary="0000000000004c61ad057ea5b523" --0000000000004c61ad057ea5b523 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 4 Jan 2019, 5:25 pm Gilles hi. > Hi Gilles, > > On Thu, 3 Jan 2019 22:04:24 +0530, Amey Jadiye wrote: > > Hello Maxim / All > > > > I put little more efforts to find out the possible cause of the > > error. > > In the clirr code, I found the reason for this error and same is > > documented > > in clirr documentation [1]. > > > > A method declaration has been added to the specified interface. This > > is > > always reported as a binary-compatibility error, but in practice, the > > changed class might be used successfully with code compiled against > > the old > > interface depending upon usage patterns. > > > > Old code which invokes methods upon code compiled against the new > > (expanded) interface will continue to work without issues. And old > > code > > which implements the old version of the interface will also continue > > to > > work correctly as long as no code attempts to invoke any of the > > newly-added > > methods against that instance. But the code which (validly) invokes > > one of > > the new methods in the interface against an object which implements > > only > > the old version of the interface will cause an AbstractMethodError to > > be > > thrown at the time the method invocation is attempted. > > IIUC, new code that calls the new methods on [Collections] classes > will crash. Does not look good. > On the other hand, Maxim wrote earlier that a method reported by > Clirr as "new" (cf. below) was in fact present since Java 6... > > Are we then sure that it's a Clirr bug? > If so, why did you not vote "+1" (on the condition that the false > positive is mentioned in the release notes)? > > We could also make some definite progress with an actual code > example that calls the incriminated methods, compiled against the > current version of the library and then run against the current RC, > and see whether it crashes. > Thanks for directions here, I must also check that. Till then I would like to change my vote to -1 (Non Binding) for this release. > Alternatively, we could instate "revapi" in the POM (and disable > Clirr); and if the report is clean, trust that (though "revapi" is > still beta). > > Opinions? > > Gilles > > > > > In 4.2 and 4.3 looks like we have upgraded the java version[2] where > > for > > example for Map interface might have added a few more methods causing > > these > > errors. > > > > For this release, I am voting 0 (Non-Binding) as there is unharmed > > mess > > around the clirr. > > > > rest of the things are OK with this release, I would encourage to > > have > > revapi replacing clirr. > > > > > > [1] http://clirr.sourceforge.net/clirr-core/exegesis.html > > [2] > > > > > https://github.com/apache/commons-collections/commit/482762a13f739631f94d= 03642b0a55a9b7214c44 > > > > Regards, > > Amey > > > > > > On Thu, Jan 3, 2019 at 11:53 AM Amey Jadiye > > wrote: > > > >> I spared little time on finding issue however didn't found it in > >> clirr(may > >> be hidden somewhere), today will check if clirr maven plugin have > >> any > >> issues. also I saw that few other apache commons modules having same > >> issue > >> and are released. > >> > >> I also gave try on revapi with commons collection4 4.3RC2. > >> revapi:check > >> was clean unlike clirr, looks promising to replace clirr. > >> > >> Regards, > >> Amey > >> > >> On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik >> wrote: > >> > >>> Hello All, > >>> > >>> Just checked clirr report one more time > >>> This time I took 1 error and perform investigation: > >>> > >>> "Method 'public java.util.Collection values()' has been added to an > >>> interface" org.apache.commons.collections4.BidiMap > >>> > >>> In fact I don't understand why this error was reported > >>> BidiMap extends java.util.Map > >>> Map has method "public java.util.Collection values()" in all > >>> versions: > >>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html > >>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html > >>> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html > >>> > >>> Maybe its clirr issue? > >>> Would appreciate any help with this investigation > >>> > >>> On Mon, 31 Dec 2018 at 16:53, Gilles > >>> wrote: > >>> > > >>> > On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote: > >>> > > Hello Gilles, > >>> > > > >>> > > I already did analysis: [1], all errors are caused by previous > >>> > > release > >>> > > 4.3 doesn't introduce any new errors ... > >>> > > > >>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt > >>> > > >>> > I had seen the post but it says: > >>> > --- > >>> > these errors are weird. Above classes has no changes comparing to > >>> 4.2 > >>> > --- > >>> > > >>> > But IMHO it was not a conclusion: If the cause of the errors was > >>> > identified, it could have been mentioned in the release notes > >>> > and/or the [VOTE] email, in order to avoid further questioning. > >>> > > >>> > Is the cause the change of supported JDK? > >>> > > >>> > Regards, > >>> > Gilles > >>> > > >>> > > > >>> > > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins > >>> > > wrote: > >>> > >> > >>> > >> I=E2=80=99ll give it a look tonight or in the morning. > >>> > >> > >>> > >> -Rob > >>> > >> > >>> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik > >>> > >> wrote: > >>> > >> > > >>> > >> > No votes after 3 days :( > >>> > >> > Is there anything wrong with the RC? > >>> > >> > > >>> > >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita > >>> > >> wrote: > >>> > >> >> > >>> > >> >> FWIW I had a similar experience, and realized I was doing > >>> `git > >>> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags` > >>> did > >>> the > >>> > >> trick. After that I could `git checkout $tag-name` > >>> > >> >> > >>> > >> >> Cheers > >>> > >> >> Bruno > >>> > >> >> > >>> > >> >> > >>> > >> >> > >>> > >> >> > >>> > >> >> ________________________________ > >>> > >> >> From: Gilles > >>> > >> >> To: dev@commons.apache.org > >>> > >> >> Sent: Thursday, 27 December 2018 9:26 AM > >>> > >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3 > >>> > >> >> > >>> > >> >> > >>> > >> >> > >>> > >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote: > >>> > >> >>> Hi. > >>> > >> >>> > >>> > >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik > >>> wrote: > >>> > >> >>>> This is a [VOTE] for releasing > >>> > >> >>>> Apache Commons collections 4.3 > >>> > >> >>>> > >>> > >> >>>> Tag name: > >>> > >> >>>> collections-4.3-RC2 (signature can be checked from git > >>> using > >>> > >> >>>> 'git > >>> > >> >>>> tag -v') > >>> > >> >>> > >>> > >> >>> $ git tag -v collections-4.3-RC2 > >>> > >> >>> error: tag 'collections-4.3-RC2' not found. > >>> > >> >>> > >>> > >> >>> Although I see it in the link below... > >>> > >> >>> What is going on? > >>> > >> >> > >>> > >> >> Issue vanished with a fresh "clone". > >>> > >> >> [Sorry for the noise.] > >>> > >> >> > >>> > >> >> > >>> > >> >>>> RC1 was cancelled due to some release steps were not done > >>> > >> >>>> > >>> > >> >>>> Tag URL: > >>> > >> >>>> > >>> > >> >>>> > >>> > >> >>>> > >>> > >> > >>> > >>> > https://gitbox.apache.org/repos/asf?p=3Dcommons-collections.git;a=3Dcommi= t;h=3D77e37dbf238d26351edb29e95391e3df75095d01 > >>> > >> >>>> > >>> > >> >>>> Commit ID the tag points at: > >>> > >> >>>> 77e37dbf238d26351edb29e95391e3df75095d01 > >>> > >> >>>> > >>> > >> >>>> Site: > >>> > >> >>>> > >>> > >> >>>> > >>> > >> >>>> > >>> > >> > >>> > >>> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/i= ndex.html > >>> > >> >>> > >>> > >> >>> The Clirr report is still a problem: > >>> > >> >>> > >>> > >> >>> > >>> > >> >>> > >>> > >> > >>> > >>> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/c= lirr-report.html > >>> > >> >>> > >>> > >> >>> [The same errors are reported on my machine, so it's > >>> > >> >>> not a cache issue...] > >>> > >> >>> > >>> > >> >>> Regards, > >>> > >> >>> Gilles > >>> > >> >>> > >>> > >> >>>> > >>> > >> >>>> Distribution files (committed at revision 31689): > >>> > >> >>>> > >>> https://dist.apache.org/repos/dist/dev/commons/collections/ > >>> > >> >>>> > >>> > >> >>>> Distribution files hashes (SHA256): > >>> > >> >>>> commons-collections4-4.3-bin.tar.gz > >>> > >> >>>> > >>> > >> > >>> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94 > >>> > >> >>>> commons-collections4-4.3-bin.zip > >>> > >> >>>> > >>> > >> > >>> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb > >>> > >> >>>> commons-collections4-4.3-src.tar.gz > >>> > >> >>>> > >>> > >> > >>> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434 > >>> > >> >>>> commons-collections4-4.3-src.zip > >>> > >> >>>> > >>> > >> > >>> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3 > >>> > >> >>>> > >>> > >> >>>> KEYS file to check signatures: > >>> > >> >>>> https://www.apache.org/dist/commons/KEYS > >>> > >> >>>> > >>> > >> >>>> Maven artifacts: > >>> > >> >>>> > >>> > >> >>>> > >>> > >> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachecommons-1405/ > >>> > >> >>>> > >>> > >> >>>> Please select one of the following options: > >>> > >> >>>> [ ] +1 Release it. > >>> > >> >>>> [ ] +0 Go ahead; I don't care. > >>> > >> >>>> [ ] -0 There are a few minor glitches: ... > >>> > >> >>>> [ ] -1 No, do not release it because ... > >>> > >> >>>> > >>> > >> >>>> This vote will be open for at least 72 hours, i.e. until > >>> > >> >>>> 2018-12-29T14:00:00Z > >>> > >> >>>> (this is UTC time). > >>> > >> >>>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --0000000000004c61ad057ea5b523--