Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Date: Wed, 1 Jul 2015 21:56:25 +0200
From: Bernd Eckenfels <ecki@zusammenkunft.net>
To: dev@commons.apache.org
Cc: wp11158370-michael <michael@fuin.org>
Subject: [VFS-497] Re: commons-vfs pull request
Message-ID: <20150701215625.00001104.ecki@zusammenkunft.net>
In-Reply-To: 
 <117612448.343656.1435747676146.JavaMail.open-xchange@app02.ox.hosteurope.de>
References: 
 <117612448.343656.1435747676146.JavaMail.open-xchange@app02.ox.hosteurope.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hello Michael,

thanks for the reminder. For some reasons we do not get notifications
for the commons-vfs project on GitHub, but I have seen the Pull Request
in the Jira comment, thats fine to track it.

I somewhat dislike this code duplication and wished there would be a
more generic way to make the filter classes work for both projects. But
since you did all the work and it looks good (including samples and
unit tests), there is nothing stopping us from merging it.

(I have however not the time to check it, I need to do a release first)

Gruss
Bernd


 Am Wed, 1 Jul 2015 12:47:56
+0200 (CEST) schrieb wp11158370-michael <michael@fuin.org>:

> Hi Bernd,
>  
> Sorry for bothering you, but I'm not sure if you get a notification
> about pull requests for the Github copy of "commons-vfs".
>  
> I ported the file filters from "commons-io" (inclduing the unit
> tests) and need someone who can merge it into the regular code base:
>  
> https://github.com/apache/commons-vfs/pull/9
>  
> Thank you in advance for looking at it.
>  
> Cheers,
> Michael
>  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org