Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 98282 invoked from network); 8 Apr 2011 20:17:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Apr 2011 20:17:35 -0000 Received: (qmail 27036 invoked by uid 500); 8 Apr 2011 20:17:34 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 26983 invoked by uid 500); 8 Apr 2011 20:17:34 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 26976 invoked by uid 99); 8 Apr 2011 20:17:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2011 20:17:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2011 20:17:31 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 176222388AA9; Fri, 8 Apr 2011 20:17:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1090427 - in /commons/proper/lang/trunk/src: main/java/org/apache/commons/lang3/CharRange.java main/java/org/apache/commons/lang3/CharSet.java test/java/org/apache/commons/lang3/CharRangeTest.java Date: Fri, 08 Apr 2011 20:17:11 -0000 To: commits@commons.apache.org From: bayard@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110408201711.176222388AA9@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bayard Date: Fri Apr 8 20:17:10 2011 New Revision: 1090427 URL: http://svn.apache.org/viewvc?rev=1090427&view=rev Log: Making CharRange non-public. LANG-689 Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharRange.java commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSet.java commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharRangeTest.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharRange.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharRange.java?rev=1090427&r1=1090426&r2=1090427&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharRange.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharRange.java Fri Apr 8 20:17:10 2011 @@ -29,7 +29,9 @@ import java.util.NoSuchElementException; * @since 1.0 * @version $Id$ */ -public final class CharRange implements Iterable, Serializable { +// TODO: This is no longer public and will be removed later as CharSet is moved +// to depend on Range. +final class CharRange implements Iterable, Serializable { /** * Required for serialization support. Lang version 2.0. Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSet.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSet.java?rev=1090427&r1=1090426&r2=1090427&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSet.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSet.java Fri Apr 8 20:17:10 2011 @@ -206,7 +206,9 @@ public class CharSet implements Serializ * @return an array of immutable CharRange objects * @since 2.0 */ - public CharRange[] getCharRanges() { +// NOTE: This is no longer public as CharRange is no longer a public class. +// It may be replaced when CharSet moves to Range. + /*public*/ CharRange[] getCharRanges() { return set.toArray(new CharRange[set.size()]); } Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharRangeTest.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharRangeTest.java?rev=1090427&r1=1090426&r2=1090427&view=diff ============================================================================== --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharRangeTest.java (original) +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/CharRangeTest.java Fri Apr 8 20:17:10 2011 @@ -37,7 +37,8 @@ public class CharRangeTest extends TestC //----------------------------------------------------------------------- public void testClass() { - assertEquals(true, Modifier.isPublic(CharRange.class.getModifiers())); + // class changed to non-public in 3.0 + assertEquals(false, Modifier.isPublic(CharRange.class.getModifiers())); assertEquals(true, Modifier.isFinal(CharRange.class.getModifiers())); }