From commits-return-71164-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Mon Jan 22 10:26:27 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7C699180609 for ; Mon, 22 Jan 2018 10:26:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6C048160C4B; Mon, 22 Jan 2018 09:26:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A94C9160C3A for ; Mon, 22 Jan 2018 10:26:26 +0100 (CET) Received: (qmail 97184 invoked by uid 500); 22 Jan 2018 09:26:25 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 97175 invoked by uid 99); 22 Jan 2018 09:26:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jan 2018 09:26:25 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group Message-ID: <151661318525.13869.8552656743933656709.gitbox@gitbox.apache.org> wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162882114 ########## File path: scripts/vm/network/security_group.py ########## @@ -951,16 +951,15 @@ def parse_network_rules(rules): if rules is None or len(rules) == 0: return ret - lines = rules.split(';')[:-1] + lines = rules.split('NEXT;')[:-1] Review comment: 
I:icmp;-1;-1;0.0.0.0/0,NEXT;I:tcp;0;65535;0.0.0.0/0,NEXT;I:udp;0;65535;0.0.0.0/0,NEXT;
Sure, this is how it looks like. The NEXT word is the last word before a new rule/line starts ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services