From commits-return-70186-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sat Jan 6 18:32:54 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7724318062C for ; Sat, 6 Jan 2018 18:32:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 67152160C3B; Sat, 6 Jan 2018 17:32:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D474C160C19 for ; Sat, 6 Jan 2018 18:32:53 +0100 (CET) Received: (qmail 96742 invoked by uid 500); 6 Jan 2018 17:32:53 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 96733 invoked by uid 99); 6 Jan 2018 17:32:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jan 2018 17:32:52 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on a change in pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster Message-ID: <151525997245.32110.2461243719692597615.gitbox@gitbox.apache.org> rhtyd commented on a change in pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#discussion_r160030725 ########## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java ########## @@ -151,16 +151,8 @@ public VmwareServerDiscoverer() { clusterDetails.put("password", password); _clusterDetailsDao.persist(clusterId, clusterDetails); } - String updatedInventoryPath = validateCluster(url, vmwareDc); - try { - if (!URLDecoder.decode(url.getPath(), "UTF-8").equals(updatedInventoryPath)) { - // If url from API doesn't specify DC then update url in database with DC associated with this zone. - clusterDetails.put("url", url.getScheme() + "://" + url.getHost() + updatedInventoryPath); - _clusterDetailsDao.persist(clusterId, clusterDetails); Review comment: @sureshanaparti could not persisting the url in the cluster details cause regression? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services