From commits-return-69871-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri Jan 5 08:48:47 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B1D00180647 for ; Fri, 5 Jan 2018 08:48:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A195F160C27; Fri, 5 Jan 2018 07:48:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF166160C19 for ; Fri, 5 Jan 2018 08:48:46 +0100 (CET) Received: (qmail 12131 invoked by uid 500); 5 Jan 2018 07:48:46 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 12122 invoked by uid 99); 5 Jan 2018 07:48:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 07:48:46 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] DaanHoogland commented on a change in pull request #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. Message-ID: <151513852547.14226.9616769407160304401.gitbox@gitbox.apache.org> DaanHoogland commented on a change in pull request #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159822245 ########## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ########## @@ -167,35 +170,62 @@ public boolean trackVmHostChange() { @Override public Pair getCommandHostDelegation(long hostId, Command cmd) { Review comment: in terms of cyclic complexity this method doesn't improve ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services