Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5089F180630 for ; Tue, 2 Jan 2018 12:35:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 409B8160C26; Tue, 2 Jan 2018 11:35:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7EB5A160C1B for ; Tue, 2 Jan 2018 12:35:18 +0100 (CET) Received: (qmail 16537 invoked by uid 500); 2 Jan 2018 11:35:17 -0000 Mailing-List: contact commits-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list commits@cloudstack.apache.org Received: (qmail 16528 invoked by uid 99); 2 Jan 2018 11:35:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2018 11:35:17 +0000 From: GitBox To: commits@cloudstack.apache.org Subject: [GitHub] rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? Message-ID: <151489291703.19415.4290504725117925973.gitbox@gitbox.apache.org> archived-at: Tue, 02 Jan 2018 11:35:19 -0000 rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-354748996 @mrunalinikankariya no, not without regression tests. Please also see the left comments specifically around refactoring the code. Thanks. @blueorangutan package ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services