cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bwsw commented on a change in pull request #2389: CLOUDSTACK-10213: Allow specify SSH key lengh
Date Thu, 01 Jan 1970 00:00:00 GMT
bwsw commented on a change in pull request #2389: CLOUDSTACK-10213: Allow specify SSH key lengh
URL: https://github.com/apache/cloudstack/pull/2389#discussion_r160107085
 
 

 ##########
 File path: server/src/com/cloud/server/ManagementServerImpl.java
 ##########
 @@ -696,6 +696,8 @@
 
     static final ConfigKey<Integer> vmPasswordLength = new ConfigKey<Integer>("Advanced",
Integer.class, "vm.password.length", "6",
                                                                                       "Specifies
the length of a randomly generated password", false);
+    static final ConfigKey<Integer> sshKeyLength = new ConfigKey<Integer>("Advanced",
Integer.class, "ssh.key.length",
+            "2048", "User SSH key length (bit)", true, ConfigKey.Scope.Account);
 
 Review comment:
   Might the description be more meaningful for average user, like "Specifies minimal? amount
of SSH key length permitted". Could you please take a look at this. May be it can be improved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message