cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rhtyd commented on a change in pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster
Date Thu, 01 Jan 1970 00:00:00 GMT
rhtyd commented on a change in pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add
a host with space in its name to existing VMware cluster
URL: https://github.com/apache/cloudstack/pull/1891#discussion_r160030725
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
 ##########
 @@ -151,16 +151,8 @@ public VmwareServerDiscoverer() {
                 clusterDetails.put("password", password);
                 _clusterDetailsDao.persist(clusterId, clusterDetails);
             }
-            String updatedInventoryPath = validateCluster(url, vmwareDc);
-            try {
-                if (!URLDecoder.decode(url.getPath(), "UTF-8").equals(updatedInventoryPath))
{
-                    // If url from API doesn't specify DC then update url in database with
DC associated with this zone.
-                    clusterDetails.put("url", url.getScheme() + "://" + url.getHost() + updatedInventoryPath);
-                    _clusterDetailsDao.persist(clusterId, clusterDetails);
 
 Review comment:
   @sureshanaparti could not persisting the url in the cluster details cause regression?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message