cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] houthuis commented on a change in pull request #2382: CLOUDSTACK-4045
Date Thu, 01 Jan 1970 00:00:00 GMT
houthuis commented on a change in pull request #2382: CLOUDSTACK-4045 
URL: https://github.com/apache/cloudstack/pull/2382#discussion_r159235216
 
 

 ##########
 File path: server/src/com/cloud/network/IpAddressManagerImpl.java
 ##########
 @@ -1394,6 +1380,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long networkId,
boolean
         }
     }
 
+    protected boolean isSourceNatAvailableForNetwork(long networkId, Account owner, IPAddressVO
ipToAssoc, Network network) {
 
 Review comment:
   no, not really. must be a result of intellij's extract method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message