Mailing-List: contact dev-help@clerezza.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@clerezza.apache.org
Received-SPF: error (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: <51E27639.1000504@xup.nl>
References: <51DFF7D8.5020008@xup.nl>
	<CALvhUEXFGqSbj5graWcJHrQ9EUtm9yfykzvejKVLFMVuPoTAzg@mail.gmail.com>
	<51E0029C.3060204@xup.nl>
	<CALvhUEV_NS=PDL23DfBD2b0jntWeCSoQUMBa+Eaafw8aog46-g@mail.gmail.com>
	<51E01D73.1030905@xup.nl>
	<CALvhUEXd7TygOnJYOhQ1=hOwNnM1X+TbbO7-rT97OP3PCu61ng@mail.gmail.com>
	<51E02B4D.6030407@xup.nl>
	<51E06B8C.5020001@xup.nl>
	<CALvhUEXFas_c8Vd0jXrDjkV00rs4eVJ_P8CD4qvxytukamp0-A@mail.gmail.com>
	<51E27639.1000504@xup.nl>
Date: Sun, 14 Jul 2013 19:12:24 +0200
Message-ID: 
 <CALvhUEWcvKtOYyDKS7gLioB08tYEMtyBAjABBzSx659=VhkdJg@mail.gmail.com>
Subject: Re: ERROR: Quad: object cannot be null
From: =?ISO-8859-1?Q?Reto_Bachmann=2DGm=FCr?= <reto@wymiwyg.com>
To: dev@clerezza.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Minto

I'm sorry for having introduced this problem. I just noticed that
BaseTdbTcProvider completely ignored the specified default graph. Not
sure what I thought exacly setting it to null. I guess it was the
incomplete ste of setting it to the actually wanted default graph.

The problem is that by the jena design we would need to prevent
concurrent queries with different default graphs. So I think it might
be better to add a FROM-clause to the query if the query doesn't
already has one. This would require again some parsing. The preparser
seems to be the place to do this. WDYT, can we do a solution that
actually provided support for the specified default graph or should we
first just provide a release that ignores it without NPE?


Cheers,
Reto

On Sun, Jul 14, 2013 at 11:58 AM, Minto van der Sluis <minto@xup.nl> wrote:
> Hi Reto,
>
> If I am correct the NPE I discovered will always happens for fastlaned
> queries on Jena TDB based TcProviders due to the following line present
> in BaseTdbTcProvider.java:
>
>     getDataset().setDefaultModel(null);
>
> The NPE can be clearly seen in DatasetImpl if model is null:
>
>     @Override
>     public void setDefaultModel(Model model)
>     {
>         // Assumes single writer.
>         removeFromCache(dsg.getDefaultGraph()) ;
>         addToCache(model) ;
>         dsg.setDefaultGraph(model.getGraph()) ;
>     }
>
> Did you have anything special in mind when you added the null model?
>
> Regards,
>
> Minto
>
> Op 12-7-2013 23:50, Reto Bachmann-Gm=FCr schreef:
>> Thanks Minto. I would rather not withdraw the release candidate but
>> have a new release very soon (max a couple of weeks).
>>
>> Reto
>>
>> On Fri, Jul 12, 2013 at 10:48 PM, Minto van der Sluis <minto@xup.nl> wro=
te:
>>> Fixed this with commit r1502677 (CLEREZZA-802)
>>>
>>> Please have a close look. Might need to be part of the pending release
>>> as well.
>>>
>>> Regards,
>>>
>>> Minto
>>>
>>> Op 12-7-2013 18:14, Minto van der Sluis schreef:
>>>> This time I end up with an NPE, see stack below.
>>>>
>>>> My changes resulted in the following
>>>>
>>>>     public Object executeSparqlQuery(String query, TripleCollection
>>>> defaultGraph, boolean forceFastlane) throws ParseException {
>>>>         TcProvider singleTargetTcProvider =3D null;
>>>>         if (forceFastlane) {
>>>>             singleTargetTcProvider =3D getSingleTargetTcProvider();
>>>>         } else {
>>>>             final UriRef defaultGraphName =3D new
>>>> UriRef("urn:x-temp:/kjsfadfhfasdffds");
>>>>             SparqlPreParser sparqlPreParser =3D new SparqlPreParser(th=
is);
>>>>             final Set<UriRef> referencedGraphs =3D
>>>> sparqlPreParser.getReferredGraphs(query, defaultGraphName);
>>>>             if ((referencedGraphs !=3D null) &&
>>>> (!referencedGraphs.contains(defaultGraphName))) {
>>>>                 singleTargetTcProvider =3D
>>>> getSingleTargetTcProvider(referencedGraphs);
>>>>             }
>>>>         }
>>>>
>>>>         if ((singleTargetTcProvider !=3D null) && (singleTargetTcProvi=
der
>>>> instanceof QueryableTcProvider)) {
>>>>             return
>>>> ((QueryableTcProvider)singleTargetTcProvider).executeSparqlQuery(query=
,
>>>> null);
>>>>         }
>>>>         final QueryEngine queryEngine =3D this.queryEngine;
>>>>         if (queryEngine !=3D null) {
>>>>             return queryEngine.execute(this, defaultGraph, query);
>>>>         } else {
>>>>             throw new NoQueryEngineException();
>>>>         }
>>>>     }
>>>>
>>>>    private TcProvider getSingleTargetTcProvider() {
>>>>         return providerList.first();
>>>>     }
>>>>
>>>> I guess the following like in BaseTdbTcProvider.executeSparqlQuery() i=
s
>>>> the culprit:
>>>>
>>>>        getDataset().setDefaultModel(null);
>>>>
>>>> Stacktrace:
>>>>
>>>> java.lang.NullPointerException
>>>>     at
>>>> com.hp.hpl.jena.sparql.core.DatasetImpl.addToCache(DatasetImpl.java:25=
9)
>>>>     at
>>>> com.hp.hpl.jena.sparql.core.DatasetImpl.setDefaultModel(DatasetImpl.ja=
va:214)
>>>>     at
>>>> org.apache.clerezza.rdf.jena.tdb.storage.BaseTdbTcProvider.executeSpar=
qlQuery(BaseTdbTcProvider.java:39)
>>>>     at
>>>> org.apache.clerezza.rdf.jena.tdb.storage.ScalableSingleTdbDatasetTcPro=
vider.executeSparqlQuery(ScalableSingleTdbDatasetTcProvider.java:81)
>>>>     at
>>>> org.apache.clerezza.rdf.core.access.TcManager.executeSparqlQuery(TcMan=
ager.java:310)
>>>>     at
>>>> org.apache.clerezza.rdf.core.access.TcManager.executeSparqlQuery(TcMan=
ager.java:282)
>>>>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>> Method)[:1.7.0_17]
>>>>     at
>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.j=
ava:57)[:1.7.0_17]
>>>>     at
>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccess=
orImpl.java:43)[:1.7.0_17]
>>>>     at java.lang.reflect.Method.invoke(Method.java:601)[:1.7.0_17]
>>>>     at
>>>> org.apache.aries.proxy.impl.ProxyHandler$1.invoke(ProxyHandler.java:54=
)[12:org.apache.aries.proxy.impl:1.0.0]
>>>>     at
>>>> org.apache.aries.proxy.impl.ProxyHandler.invoke(ProxyHandler.java:119)=
[12:org.apache.aries.proxy.impl:1.0.0]
>>>>     at
>>>> org.apache.clerezza.rdf.core.access.$TcManager10360330.executeSparqlQu=
ery(Unknown
>>>> Source)[181:org.apache.clerezza.rdf.core:0.13.0.SNAPSHOT]
>>>>     at
>>>> nl.overheid.stelsel.digimelding.astore.storage.clerezza.ClerezzaStorag=
eProvider.query(ClerezzaStorageProvider.java:250)[209:astore-storage-clerez=
za:0.7.0.SNAPSHOT]
>>>>
>>>
>>> --
>>> ir. ing. Minto van der Sluis
>>> Software innovator / renovator
>>> Xup BV
>>>
>>> Mobiel: +31 (0) 626 014541
>>>
>>
>
>
> --
> ir. ing. Minto van der Sluis
> Software innovator / renovator
> Xup BV
>
> Mobiel: +31 (0) 626 014541
>