From dev-return-11165-archive-asf-public=cust-asf.ponee.io@cayenne.apache.org Fri Apr 3 11:57:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 63F1518064F for ; Fri, 3 Apr 2020 13:57:31 +0200 (CEST) Received: (qmail 16826 invoked by uid 500); 3 Apr 2020 11:57:30 -0000 Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cayenne.apache.org Delivered-To: mailing list dev@cayenne.apache.org Received: (qmail 16813 invoked by uid 99); 3 Apr 2020 11:57:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2020 11:57:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 331BCC08D7 for ; Fri, 3 Apr 2020 11:57:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.954 X-Spam-Level: * X-Spam-Status: No, score=1.954 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, JMQ_SPF_NEUTRAL=0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.652, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=objectstyle-com.20150623.gappssmtp.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ecgSv1iJPscg for ; Fri, 3 Apr 2020 11:57:27 +0000 (UTC) Received-SPF: Neutral (mailfrom) identity=mailfrom; client-ip=209.85.166.53; helo=mail-io1-f53.google.com; envelope-from=ntimofeev@objectstyle.com; receiver= Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 8E946BB87E for ; Fri, 3 Apr 2020 11:57:27 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id s15so7168931ioj.7 for ; Fri, 03 Apr 2020 04:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=objectstyle-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ML8zIjHiyBzqOqA5ecf1KpCkKinHIzRZ5Vx1yjpOlM0=; b=0XlHCd/cHnPSAV9cj0L/BPrszrFXUue1b09hh9fem4MSUe7UOx4GvJvKA8MK6XKD5q /+9KlNT0IY4Et23GdArT1WXv94R5vvXkFBa8QHdYeuLeNzSNUaEYDaqsqapwV4sUe+Wj OSPwEK+9lM6f92ByYYmZRrhViOnDzbGwUWnyBvCH1stI5+pnRQaPnjDxAaGIlxQ1bsPO AsFqCLy9Al5x9g5V21e3+r2cS7V7UHKcS0eYvVLGGeAvyXY8X9OhQrJ+27XxlbSpwrEd WrbhfKYUUD0xFFSSD4+e+dLzTx2P9m0KN2Xv8y4lzlq9UJaPTuPAWl5z4LePI4XW05cY TB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ML8zIjHiyBzqOqA5ecf1KpCkKinHIzRZ5Vx1yjpOlM0=; b=qu3PR/S1Jap/ZLTuxTN098YTq/fCR8eazGrcLETZkUU/jsFAhHJfwgigiZgdrLdSMS GmVqRr6edQ3hXRgInFilOagebKzO55fbZsXqAjzLuoqKtETPQMjadVo2sGnHI9uOaZdS q63XiWA/9OD529RTrkxZMkan1z39Bz2K5Dc7MPf388IlRfUqGOeLqHR4qLqzs6TuxbrE 2z4GiHcKj97t3N3JzBqyhGo3/mhEYL70/+qUsdkb9ZzSfSMOEiyhCgT7+1JWuq6ae/Lb fR+9hFPxsezId49/nWBC2/GJbRrLecD26cJWmBfdoUUtMvXfM5tpxXh+VjhGD45JLLJ2 dgwQ== X-Gm-Message-State: AGi0PuaHkCwMq/sSpIeG6z0NM/K+UTSLVDiXcKmVUmuJyJWLvPBtriwA LP8rRDGW6agK9LusD3IoMqIcdAuhlJffD6oNefNGO0OOGWs= X-Google-Smtp-Source: APiQypK7CLN3Z/GUxRI1Bbvv9gf/SC7pFJDPo6FpQJbtKTUeadvZt+0ESzmiMZ+aXkWfo+tT9fAsHorQxPcLzn3AGdE= X-Received: by 2002:a02:455:: with SMTP id 82mr8003081jab.112.1585915046518; Fri, 03 Apr 2020 04:57:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nikita Timofeev Date: Fri, 3 Apr 2020 14:57:00 +0300 Message-ID: Subject: Re: [VOTE] Apache Cayenne 4.2.M1 release To: dev@cayenne.apache.org Content-Type: text/plain; charset="UTF-8" Hi all, I've rolled back 4.2.M1 release and will start new voting soon. Fix for the meaningful FK is committed now [1]. I've also checked that the latest snapshot version of the Apache RAT [2] is ok with the "https://", so we could use it. I'll update docs and also will mention the maven plugin. John, could you please check again your meaningful FK test case with the latest cayenne snapshot build? [1] https://issues.apache.org/jira/browse/CAY-2652 [2] https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/ On Sat, Mar 28, 2020 at 1:04 AM John Huss wrote: > > Thanks. > > I figured out the problem with cgen was that I had velocity-engine-core-2.0 > instead of velocity-engine-core-2.1. Updating the jar fixed the problem. > > > On Thu, Mar 26, 2020 at 12:25 PM Nikita Timofeev > wrote: > > > Thank you, John, for your thorough testing. > > > > 1. Seems like RAT don't like the change from "http://" to "https://" > > in the license text. I've updated settings for the RAT maven plugin > > (as I use it to check sources) and that works ok. Need to update > > config for the standalone script. > > 2. Cgen + ant. IIRC we had some problems with that and you helped a > > lot with it. I've tested cgen task in a simple demo project and it > > works fine for me, but I don't really know much about the Ant. > > If you can create a demo project or help somehow else, that would be great. > > 3. I was able to reproduce this one. Primitive type in the meaningful > > FK really creating problems, so need to fix this. > > > > I'll keep this vote open in case something else comes up. > > > > On Thu, Mar 26, 2020 at 1:05 AM John Huss wrote: > > > > > > Thanks for all your work on this. 4.2 is going to be a great release! I > > ran > > > all my checks on the release and almost everything passed. > > > > > > I don't know what changed, but I'm having a RAT problem I haven't seen > > > before. RAT (both 0.12 and 0.13) show this header: > > > > > > Printing headers for text files without a valid license header... > > > > > > > > > then lists basically every source file in the archive, example below. > > When > > > I open this file directly the license header is there, but the printout > > > from RAT doesn't show it. > > > > > > ===================================================== > > > > > > == File: > > > > > cayenne-4.2.M1-src/cayenne-osgi/src/test/java/org/apache/cayenne/configuration/osgi/OsgiClassLoaderManagerTest.java > > > > > > ===================================================== > > > > > > /***************************************************************** > > > > > > * > > > > > > * > > > > > > ****************************************************************/ > > > > > > package org.apache.cayenne.configuration.osgi; > > > > > > > > > import org.junit.Test; > > > > > > > > > import java.util.Collections; > > > > > > > > > import static org.junit.Assert.assertSame; > > > > > > import static org.mockito.Mockito.mock; > > > > > > > > > public class OsgiClassLoaderManagerTest { > > > > > > > > > > > > > > ----------------------------------------------------------------------------------------------------------------------------- > > > More importantly, I'm seeing some issues with cgen (using ant) not > > finding > > > templates. This wasn't happening when I tested 4.2 months ago, so it must > > > be a more recent change. > > > > > > org.apache.velocity.exception.ResourceNotFoundException: Unable to find > > > resource 'templates/v4_1/superclass.vm' > > > > > > > > > > > > > > > > > > > > superpkg="com.myapp.auto" > > > > > > createpropertynames="true" > > > > > > destDir="src" > > > > > > outputPattern="*.java" > > > > > > usepkgpath="true" > > > > > > encoding="UTF-8" > > > > > > mode="all" > > > > > > force="true" > > > > > > /> > > > > > > > > > > > > > > > > > > The unit tests in my projects are looking nearly perfect. But I did see a > > > regression in a very specific case. I have an entity with a meaningful > > > foreign key attribute that is modeled as a primitive (int). The attribute > > > is the same column as referenced by a relationship on the same entity. > > This > > > was working in the previous version but isn't working now. The value is > > > just always zero for this field now. I'm not sure if this is supposed to > > be > > > supported. > > > > > > > > > On Tue, Mar 24, 2020 at 4:55 AM Nikita Timofeev < > > ntimofeev@objectstyle.com> > > > wrote: > > > > > > > Hi all, > > > > > > > > Here is a long-awaited 4.2.M1 release. > > > > JIRA tells that it has impressive 100 issues resolved. > > > > > > > > Release notes: > > > > https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt > > > > Maven repo: > > > > > > https://repository.apache.org/content/repositories/orgapachecayenne-1037/ > > > > Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.2.M1/ > > > > > > > > Please evaluate and cast your votes. > > > > > > > > -- > > > > Best regards, > > > > Nikita Timofeev > > > > > > > > > > > > -- > > Best regards, > > Nikita Timofeev > > -- Best regards, Nikita Timofeev