Mailing-List: contact dev-help@cayenne.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cayenne.apache.org
From: Andrus Adamchik <andrus@objectstyle.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: DataRowStore properties
Date: Tue, 27 Jun 2017 09:55:40 -0400
References: <d8540402-0c8a-0e1f-b382-ae61992e3661@maniatis.org>
To: dev@cayenne.apache.org
In-Reply-To: <d8540402-0c8a-0e1f-b382-ae61992e3661@maniatis.org>
Message-Id: <62B44451-3149-47E3-AA94-BC28A7BC0C56@objectstyle.org>
archived-at: Tue, 27 Jun 2017 13:55:47 -0000

I agree, this is confusing. This API is only half-way converted to the =
DI style of configuration. So yeah, it doesn't make sense (except as =
transitional API that needs to be cleaned up). Ideally all stack objects =
should be immutable and initialized with specific values, not =
properties. Properties should be decoded by factories that create those =
objects. (i.e. we need to stick to separation of configuration code from =
the object we are configuring).

We are following this approach everywhere in Bootique, and we'll =
gradually refactor towards it in Cayenne.=20

> Should SNAPSHOT_EXPIRATION_DEFAULT also be deprecated in this class?

Yes. I think in 4.1 we should.

Andrus


> On Jun 26, 2017, at 9:18 PM, Aristedes Maniatis <ari@maniatis.org> =
wrote:
>=20
> I'm a little confused about the way properties are used and set in the =
DataRowStore.
>=20
>    public DataRowStore(String name, RuntimeProperties properties, =
EventManager eventManager)
>=20
> properties can be null here, but=20
>=20
>    protected void initWithProperties(RuntimeProperties properties)
>=20
> will throw NPE
>=20
>=20
> Also, initWithProperties(properties) seems to just ignore all the =
properties we pass except for SNAPSHOT_CACHE_SIZE_PROPERTY. Should =
SNAPSHOT_EXPIRATION_DEFAULT also be deprecated in this class?
>=20
>=20
> Finally, in the DataDomain class we also have properties, but instead =
of being RuntimeProperties they are just Map<String, String>. Since it =
appears that RuntimeProperties are really just an enhanced map with =
getters that support default values, should RuntimeProperties be used =
consistently? To me this whole class seems like overkill, but maybe it =
is useful.
>=20
>=20
> Ari
>=20
>=20
>=20
> --=20
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A