axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIS2-4091) WSDL11ToAxisServiceBuilder + HTTP Binding: Unused/Useless global element declations are appended into WSDL's XSD documents
Date Thu, 21 Dec 2017 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299777#comment-16299777
] 

Andreas Veithen commented on AXIS2-4091:
----------------------------------------

I'm trying to understand the issue better. It turns out that the code in question currently
has very poor test coverage; only a single low level unit test (HttpMessagesSerializationTest)
fails if the generateWrapperSchema code is completely disabled. What is the end to end scenario
that you are trying to make work? Could we use that to build an integration test?

> WSDL11ToAxisServiceBuilder + HTTP Binding: Unused/Useless global element declations are
appended into WSDL's XSD documents
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-4091
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4091
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.4, nightly
>         Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
>            Reporter: Antonio Andrade
>            Priority: Minor
>         Attachments: AXIS2-4091-trunk.patch, AXIS2-4091.patch, JUnit Tests - Before.jpg,
JUnit Tests - Half of Patch.jpg
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Observed Behavior: 
> 1) New XML schema global elements declarations are created and appended into WSDL's XSD
documents when they should not. This is the case of message <wsdl:part/>s already referencing
global element declarations (through the 'element' attribute of the message part). 
> 2) Whether a message part requires a 'wrapped' element or not can be determine by reading
the 'wrappedInput' and 'wrappedOutput' attributes of the 'BindingOperationEntry' inner class
after the message part has been analyzed but the 'addPartToElement' method fails to properly
set them for all cases (i.e. ignores whether the message part comes from an input or output
message by ignoring the 'isOutMessage' argument received).
> Expected Behavior: 
> 1) No XML schema global elements declarations should be added whenever message <wsdl:part/>s
use the 'element' attribute (i.e. already reference global element declarations).
> 2) The 'addPartToElement' method should take into account the value of the 'isOutMessage'
argument received to set the value of the 'wrappedInput' and 'wrappedOutput' attributes of
the 'BindingOperationEntry' inner class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message