On Mon, Aug 24, 2009 at 12:44 PM, Andreas Veithen <andreas.veithen@gmail.com> wrote:
Amila,

If you use your own TransportListener implementations, how do you
implement getEPRsForService such that it returns URIs with the correct
port numbers?

See here[1]. I think this is not relevant here. What I try to say is any one can implement a Transport listener in the way they need. We need to provide the support for that.

And also I think this code is not necessary as well.

httpListener = getAxisServletListener(Constants.TRANSPORT_HTTP);
            httpsListener = getAxisServletListener(Constants.TRANSPORT_HTTPS);
           
            if (httpListener == null && httpsListener == null) {
                log.warn("No transportReceiver for " + AxisServletListener.class.getName() +
                        " found. An instance for HTTP will be configured automatically. " +
                        "Please update your axis2.xml file!");
                httpListener = new AxisServletListener();
                TransportInDescription transportInDescription = new TransportInDescription(
                        Constants.TRANSPORT_HTTP);
                transportInDescription.setReceiver(httpListener);
                axisConfiguration.addTransportIn(transportInDescription);

            } else if (httpListener != null && httpsListener != null
                    && httpListener.getPort() == -1 && httpsListener.getPort() == -1) {
                log.warn("If more than one transportReceiver for " +
                        AxisServletListener.class.getName() + " exists, then all instances " +
                        "must be configured with a port number. WSDL generation will be " +
                        "unreliable.");
            }

if we go ahead with this approach we need to have two axis2.xml.
1. shift with standalone distribution which has the SimpleHttp trnasport listener
2. shift with web distribution with new Axis2Servlet listeners.

At run time, if the axis2.xml (which is inside the war file)  does not contain AxisServletListner, this means they have done their own listener extending the transprotListner. So let them handle it in that way. We don't need to initialize new things.

thanks,
Amila.

[1] https://wso2.org/repos/wso2/trunk/carbon/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/transports/http/HttpTransportListener.java


Andreas

On Mon, Aug 24, 2009 at 08:56, Amila
Suriarachchi<amilasuriarachchi@gmail.com> wrote:
> hi,
>
> I had time to go through your comment and I think what you suggest is the
> correct way to address the problem.
> So +1 for that.
>
> Then I looked into the our code and found that we have also done the same
> technique with separate two
> Transport listeners :).
>
> Because we have our own two transport listeners this code gives us problems,
>
> // This method should not be part of the public API. In particular we must
> not allow subclasses
>     // to override this method because we don't make any guarantees as to
> when exactly this method
>     // is called.
>     private void preprocessRequest(HttpServletRequest req) throws
> ServletException {
>         initContextRoot(req);
>
>         AxisServletListener listener = req.isSecure() ? httpsListener :
> httpListener;
>         if (listener == null) {
>             throw new ServletException(req.getScheme() + " is forbidden");
>         } else {
>             // Autodetect the port number if necessary
>             if (listener.getPort() == -1) {
>                 listener.setPort(req.getServerPort());
>             }
>         }
>     }
>
> Here you assume anyone use Axis2 as a library has used AxisServletListner
> and kept it as a private variable in Axis2Servlet.
>
> Instead of I would like to implement this method like this,
>
>
> // This method should not be part of the public API. In particular we must
> not allow subclasses
>     // to override this method because we don't make any guarantees as to
> when exactly this method
>     // is called.
>     private void preprocessRequest(HttpServletRequest req) throws
> ServletException {
>         initContextRoot(req);
>
>         TransportInDescription transportInDescription =
>                 req.isSecure() ?
> this.axisConfiguration.getTransportIn(Constants.TRANSPORT_HTTPS) :
>
> this.axisConfiguration.getTransportIn(Constants.TRANSPORT_HTTP);
>         if (transportInDescription == null) {
>             throw new ServletException(req.getScheme() + " is forbidden");
>         } else {
>             if (transportInDescription.getReceiver() instanceof
> AxisServletListener) {
>                 AxisServletListener listener = (AxisServletListener)
> transportInDescription.getReceiver();
>                 if (listener.getPort() == -1) {
>                     listener.setPort(req.getServerPort());
>                 }
>             }
>         }
>     }
>
> In this way we do not keep the Axis2Specific listener and take it from the
> axis configuration and check for port only if it is an Axis2Servlet
> listener.
>
> WDYT?
>
> thanks,
> Amila.
>
>
>
> On Sat, Aug 22, 2009 at 12:45 PM, Srinath Perera <hemapani@gmail.com> wrote:
>>
>> > I am not sure whether clearly understand the difference between how
>> > AxisServelet works and how SimpleHTTPServer works. In the case of
>> > AxisServlet, we first start AxisServlet and then we start Axis2, so when
>> > we start Axis2 we already have HTTP listener running (and hence
>> > TransportInDec). So once the system start we just create a
>> > TransportInDec using servlet and set that as the HTTP TransportDec (and
>> > of course we replace what is in axis2.xml for HTTP with this
>> > transportInDec, and we must do that). Whereas in SimpleHTTPServer, we
>> > first start Axis2 and then we use transport in axis2.xml to configure
>> > the system, so we use the tarnporInDec to configure the
>> > SimpleHTTPServer.
>>
>> Yep, this is right. One reason it is there is that to allow both
>> simple HTTP server and servlet share the same axis2.xml which is not
>> required, rather a convenience. In a servlet case transport receiver
>> is not initialized at all (I do not think it has changed).
>>
>> Thanks
>> Srinath
>>
>> --
>> ============================
>> Srinath Perera, Ph.D.
>>   WSO2 Inc. http://wso2.com
>>   Blog: http://srinathsview.blogspot.com/
>
>
>
> --
> Amila Suriarachchi
> WSO2 Inc.
> blog: http://amilachinthaka.blogspot.com/
>



--
Amila Suriarachchi
WSO2 Inc.
blog: http://amilachinthaka.blogspot.com/