From issues-return-626-archive-asf-public=cust-asf.ponee.io@avro.apache.org Mon Mar 22 15:17:49 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 2DF4B180621 for ; Mon, 22 Mar 2021 16:17:49 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 6C49942551 for ; Mon, 22 Mar 2021 15:17:48 +0000 (UTC) Received: (qmail 24694 invoked by uid 500); 22 Mar 2021 15:17:48 -0000 Mailing-List: contact issues-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list issues@avro.apache.org Received: (qmail 24685 invoked by uid 99); 22 Mar 2021 15:17:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Mar 2021 15:17:48 +0000 From: =?utf-8?q?GitBox?= To: issues@avro.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bavro=5D_mitjap_commented_on_pull_request_=231150?= =?utf-8?q?=3A_AVRO-3088=3A_use_modern_CMake_style_with_config_file?= Message-ID: <161642626812.15632.14146173811431744279.asfpy@gitbox.apache.org> Date: Mon, 22 Mar 2021 15:17:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: mitjap commented on pull request #1150: URL: https://github.com/apache/avro/pull/1150#issuecomment-804144036 This PR does two things, it uses more modern CMake with targets and better manages dependencies between targets and add installation of config files. Do you think this shuld be two separate PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org