From issues-return-585-archive-asf-public=cust-asf.ponee.io@avro.apache.org Wed Mar 3 05:39:10 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4492918064F for ; Wed, 3 Mar 2021 06:39:10 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id B287662CF8 for ; Wed, 3 Mar 2021 05:39:09 +0000 (UTC) Received: (qmail 54301 invoked by uid 500); 3 Mar 2021 05:39:09 -0000 Mailing-List: contact issues-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list issues@avro.apache.org Received: (qmail 54292 invoked by uid 99); 3 Mar 2021 05:39:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Mar 2021 05:39:08 +0000 From: =?utf-8?q?GitBox?= To: issues@avro.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bavro=5D_emkornfield_commented_on_pull_request_=239?= =?utf-8?q?73=3A_AVRO-2952=3A_AvroDatatype?= Message-ID: <161474994875.15632.13504477499183213034.asfpy@gitbox.apache.org> Date: Wed, 03 Mar 2021 05:39:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: emkornfield commented on pull request #973: URL: https://github.com/apache/avro/pull/973#issuecomment-789447944 I didn't see mention in the JIRA or here, but was this discussed on the mailing list? IIUC this is adding on custom extensions to logical types and additional metadata to the schema? If this is the case it seems like something that other implementations might care about if they will need to support later (i.e. it seems like updating the specification first with optional these optional extensions would be a good thing to do first so there is agreement on how to interpret them). Otherwise i would worry about the java code becoming the specification (which in my experience yields lower quality implementations elsewhere). If this doesn't affect serialized data or interpretation in any way please ignore my comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org