From issues-return-564-archive-asf-public=cust-asf.ponee.io@avro.apache.org Mon Mar 1 03:07:26 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 90973180652 for ; Mon, 1 Mar 2021 04:07:26 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id C95F141C77 for ; Mon, 1 Mar 2021 03:07:25 +0000 (UTC) Received: (qmail 1989 invoked by uid 500); 1 Mar 2021 03:07:25 -0000 Mailing-List: contact issues-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list issues@avro.apache.org Received: (qmail 1978 invoked by uid 99); 1 Mar 2021 03:07:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Mar 2021 03:07:25 +0000 From: =?utf-8?q?GitBox?= To: issues@avro.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bavro=5D_thiru-mg_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=231106=3A_Core_C++_implementation_is_modernized?= Message-ID: <161456804526.15632.1640855704960002071.asfpy@gitbox.apache.org> Date: Mon, 01 Mar 2021 03:07:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: thiru-mg commented on a change in pull request #1106: URL: https://github.com/apache/avro/pull/1106#discussion_r584420931 ########## File path: lang/c++/api/Decoder.hh ########## @@ -47,11 +47,11 @@ namespace avro { */ class AVRO_DECL Decoder { public: - virtual ~Decoder() { }; + virtual ~Decoder() = default;; /// All future decoding will come from is, which should be valid /// until replaced by another call to init() or this Decoder is /// destructed. - virtual void init(InputStream& is) = 0; + virtual void init(InputStream &is) = 0; Review comment: This change makes sense because int& i, j; is actually int &i, j ########## File path: lang/c++/api/Decoder.hh ########## @@ -47,11 +47,11 @@ namespace avro { */ class AVRO_DECL Decoder { public: - virtual ~Decoder() { }; + virtual ~Decoder() = default;; /// All future decoding will come from is, which should be valid /// until replaced by another call to init() or this Decoder is /// destructed. - virtual void init(InputStream& is) = 0; + virtual void init(InputStream &is) = 0; Review comment: This change makes sense because int& i, j; is actually int &i, j ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org