From issues-return-563-archive-asf-public=cust-asf.ponee.io@avro.apache.org  Mon Mar  1 03:03:16 2021
Return-Path: <issues-return-563-archive-asf-public=cust-asf.ponee.io@avro.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255])
	by mx-eu-01.ponee.io (Postfix) with ESMTPS id B65BD180652
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  1 Mar 2021 04:03:16 +0100 (CET)
Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153])
	by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id E4E7D41A92
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  1 Mar 2021 03:03:15 +0000 (UTC)
Received: (qmail 96639 invoked by uid 500); 1 Mar 2021 03:03:15 -0000
Mailing-List: contact issues-help@avro.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@avro.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@avro.apache.org>
List-Post: <mailto:issues@avro.apache.org>
List-Id: <issues.avro.apache.org>
Reply-To: dev@avro.apache.org
Delivered-To: mailing list issues@avro.apache.org
Received: (qmail 96630 invoked by uid 99); 1 Mar 2021 03:03:14 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Mar 2021 03:03:14 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: issues@avro.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bavro=5D_thiru-mg_commented_on_a_change_in_pull_req?=
 =?utf-8?q?uest_=231106=3A_Core_C++_implementation_is_modernized?=
Message-ID: <161456779429.15632.921009215600017522.asfpy@gitbox.apache.org>
Date: Mon, 01 Mar 2021 03:03:14 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <avro.1106.MDExOlB1bGxSZXF1ZXN0NTgxNDUyMTkw.gitbox@gitbox.apache.org>
In-Reply-To: <avro.1106.MDExOlB1bGxSZXF1ZXN0NTgxNDUyMTkw.gitbox@gitbox.apache.org>


thiru-mg commented on a change in pull request #1106:
URL: https://github.com/apache/avro/pull/1106#discussion_r584419941



##########
File path: lang/c++/api/NodeConcepts.hh
##########
@@ -169,51 +157,47 @@ struct MultiAttribute
         return attrs_.at(index);
     }
 
-  private:
+private:
 
     std::vector<Attribute> attrs_;
 };
 
-
 template<typename T>
 struct NameIndexConcept {
 
     bool lookup(const std::string &name, size_t &index) const {
         throw Exception("Name index does not exist");
-        return 0;
     }
 
-    bool add(const::std::string &name, size_t index) {
+    bool add(const ::std::string &name, size_t) {

Review comment:
       Will fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org