avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] thiru-mg commented on a change in pull request #1153: AVRO-3051: C++ Reader and writers modernized
Date Tue, 23 Mar 2021 17:07:08 GMT

thiru-mg commented on a change in pull request #1153:
URL: https://github.com/apache/avro/pull/1153#discussion_r599766786



##########
File path: lang/c++/api/NodeImpl.hh
##########
@@ -113,15 +113,15 @@ protected:
         return docAttribute_.get();
     }
 
-    void doAddLeaf(const NodePtr &newLeaf) override {
+    void doAddLeaf(const NodePtr &newLeaf) final {

Review comment:
       The reason this is final is because this is being invoked from the constructor. Invoking
a non-final virtual function from constructor is confusing at the very least.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message