avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] emkornfield commented on a change in pull request #1153: AVRO-3051: C++ Reader and writers modernized
Date Tue, 23 Mar 2021 15:32:48 GMT

emkornfield commented on a change in pull request #1153:
URL: https://github.com/apache/avro/pull/1153#discussion_r599681925



##########
File path: lang/c++/api/NodeImpl.hh
##########
@@ -113,15 +113,15 @@ protected:
         return docAttribute_.get();
     }
 
-    void doAddLeaf(const NodePtr &newLeaf) override {
+    void doAddLeaf(const NodePtr &newLeaf) final {
         leafAttributes_.add(newLeaf);
     }
 
     size_t leaves() const override {
         return leafAttributes_.size();
     }
 
-    const NodePtr &leafAt(int index) const override {
+    const NodePtr &leafAt(size_t index) const override {

Review comment:
       it seems you would want to make this final as well? if you are converting the one above?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message