avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] emkornfield commented on a change in pull request #1149: Avro 3089 fix cpp warnings
Date Sun, 21 Mar 2021 16:55:27 GMT

emkornfield commented on a change in pull request #1149:
URL: https://github.com/apache/avro/pull/1149#discussion_r598307486



##########
File path: lang/c++/test/DataFileTests.cc
##########
@@ -896,9 +896,9 @@ void testReadRecordEfficientlyUsingLastSync(avro::Codec codec) {
 
     const char* filename = "test_readRecordUsingLastSync.df";
     
-    int numberOfRecords = 100;
-    int recordToRead = 37;  // pick specific record to read efficiently
-    int syncPointWithRecord = 0;
+    size_t numberOfRecords = 100;
+    size_t recordToRead = 37;  // pick specific record to read efficiently
+    size_t syncPointWithRecord = 0;
     int finalSync = 0;

Review comment:
       change these variables for consistency also?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message