avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] emkornfield commented on a change in pull request #1106: Core C++ implementation is modernized
Date Mon, 01 Mar 2021 04:17:37 GMT

emkornfield commented on a change in pull request #1106:
URL: https://github.com/apache/avro/pull/1106#discussion_r584437294



##########
File path: lang/c++/api/Decoder.hh
##########
@@ -47,11 +47,11 @@ namespace avro {
  */
 class AVRO_DECL Decoder {
 public:
-    virtual ~Decoder() { };
+    virtual ~Decoder() = default;;
     /// All future decoding will come from is, which should be valid
     /// until replaced by another call to init() or this Decoder is
     /// destructed.
-    virtual void init(InputStream& is) = 0;
+    virtual void init(InputStream &is) = 0;

Review comment:
       This is a highly dogmatic topic.  If there isn't a style guide in place for Avro C++
that addresses this already, I think it is worth at least a heads up and separating it into
a different PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message