From issues-return-446-archive-asf-public=cust-asf.ponee.io@avro.apache.org Thu Jan 21 14:10:33 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A56B1180645 for ; Thu, 21 Jan 2021 15:10:33 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 411B362BE9 for ; Thu, 21 Jan 2021 14:10:33 +0000 (UTC) Received: (qmail 1033 invoked by uid 500); 21 Jan 2021 14:10:32 -0000 Mailing-List: contact issues-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list issues@avro.apache.org Received: (qmail 1024 invoked by uid 99); 21 Jan 2021 14:10:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jan 2021 14:10:32 +0000 From: =?utf-8?q?GitBox?= To: issues@avro.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bavro=5D_jviotti_commented_on_a_change_in_pull_requ?= =?utf-8?q?est_=231065=3A_AVRO-3028=3A_Records_encode_fields_that_equal_the_?= =?utf-8?q?default?= Message-ID: <161123823255.15632.17788987564838543838.asfpy@gitbox.apache.org> Date: Thu, 21 Jan 2021 14:10:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: jviotti commented on a change in pull request #1065: URL: https://github.com/apache/avro/pull/1065#discussion_r561909119 ########## File path: doc/src/content/xdocs/spec.xml ########## @@ -564,7 +565,7 @@ followed by the serialized string: 02 02 61 -

NOTE: Currently for C/C++ implementtions, the positions are practically an int, but theoretically a long. +

NOTE: Currently for C/C++ implementtions, the positions are practically an int, but theoretically a long. Review comment: Sounds good. I'll add this change to the commit! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org