avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] unchuckable commented on pull request #973: AVRO-2952: AvroDatatype
Date Sat, 23 Jan 2021 20:10:14 GMT

unchuckable commented on pull request #973:
URL: https://github.com/apache/avro/pull/973#issuecomment-766172140


   Hi, Werner,
   
   that’s nice to hear. (Also good to hear about the main build not being on PASS, because
that could explain issues with my own PR ;)). Mind you that I cannot accept your PR but was
merely trying to offer constrictive remarks that might be made by others during the review.
Lets hope one of the commited maintainers can find the time to review timely.
   
   
   
   > On 23. Jan 2021, at 21:05, wernerdaehn <notifications@github.com> wrote:
   > 
   > 
   > @unchuckable <https://github.com/unchuckable>
   > Hi Martin, I made the agreed changes and more of what you have requested initially.
For example the hashCode(), the toString(StringBuffer) etc.
   > Will check in the code as soon as the main build is on PASS again.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/avro/pull/973#issuecomment-766171549>,
or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDPCL4NPOPNAPEUKPS3HRDS3MT2BANCNFSM4TH4WI3A>.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message