avro-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [avro] RyanSkraba commented on a change in pull request #1065: AVRO-3028: Records encode fields that equal the default
Date Thu, 21 Jan 2021 13:42:33 GMT

RyanSkraba commented on a change in pull request #1065:
URL: https://github.com/apache/avro/pull/1065#discussion_r561887441



##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -564,7 +565,7 @@
                 followed by the serialized string:
                 <source>02 02 61</source></li>
             </ul>
-            <p><em>NOTE</em>: Currently for C/C++ implementtions, the positions
are practically an int, but theoretically a long. 
+            <p><em>NOTE</em>: Currently for C/C++ implementtions, the positions
are practically an int, but theoretically a long.

Review comment:
       ```suggestion
               <p><em>NOTE</em>: Currently for C/C++ implementations, the
positions are practically an int, but theoretically a long.
   ```
   While you're at this sentence :D




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message