From notifications-return-123534-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org Sat Oct 27 01:05:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6088C180647 for ; Sat, 27 Oct 2018 01:05:04 +0200 (CEST) Received: (qmail 52251 invoked by uid 500); 26 Oct 2018 23:05:03 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 52242 invoked by uid 99); 26 Oct 2018 23:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 23:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 07C27C22AD for ; Fri, 26 Oct 2018 23:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pNG-ldU2PkN3 for ; Fri, 26 Oct 2018 23:05:02 +0000 (UTC) Received: from vitalstatistix.ics.uci.edu (vitalstatistix.ics.uci.edu [128.195.52.38]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B70FA5F1E3 for ; Fri, 26 Oct 2018 23:05:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vitalstatistix.ics.uci.edu (Postfix) with ESMTP id 31E3E100088; Fri, 26 Oct 2018 16:05:01 -0700 (PDT) Date: Fri, 26 Oct 2018 16:05:01 -0700 From: "Till Westmann (Code Review)" To: Murtadha Hubail CC: Jenkins Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic X-Gerrit-Change-Id: I38254582e08d97951a949f7327c8c3d7cf2ab51d X-Gerrit-ChangeURL: X-Gerrit-Commit: 50c7f8ff68da6592d0a93493fc50605ca7f968b0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20181026230501.31E3E100088@vitalstatistix.ics.uci.edu> Till Westmann has posted comments on this change. Change subject: [NO ISSUE][ING] Refactor Active Suspend/Resume Logic ...................................................................... Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2999/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java: PS2, Line 258: LOGGER pull the logging out (as below)? PS2, Line 261: registeredListeners inline (as below)? PS2, Line 289: dataverseName + '.' + entityName Just a question: Could we just use the toString of the EntityId here? https://asterix-gerrit.ics.uci.edu/#/c/2999/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS1, Line 728: validateIfResourceIsActiveInFeed > a) I put it back. However, I feel like this should be a runtime data except a) Metadata operations are always tricky. As they happen during the compilation phase of a request a CompilationException doesn't seem to be inadequate - at least at the outermost level. In other cases where we execute something during compilation (e.g. during constant folding) we'll execute, get a runtime exception ,and have the compiler report is as a compilation exception. PS1, Line 2966: validateDatasetSta > Where I come from, callBeforeXHook is called beforeX :) I understand the original naming scheme, but I think that the current name is easier to grasp on first contact. -- To view, visit https://asterix-gerrit.ics.uci.edu/2999 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38254582e08d97951a949f7327c8c3d7cf2ab51d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes