Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F241A200CDD for ; Mon, 7 Aug 2017 16:52:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF0EE1656FF; Mon, 7 Aug 2017 14:52:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 40E801656FC for ; Mon, 7 Aug 2017 16:52:52 +0200 (CEST) Received: (qmail 9384 invoked by uid 500); 7 Aug 2017 14:52:51 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 9375 invoked by uid 99); 7 Aug 2017 14:52:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Aug 2017 14:52:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DEB4C180414 for ; Mon, 7 Aug 2017 14:52:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EEI3D604ox75 for ; Mon, 7 Aug 2017 14:52:46 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0085C5F249 for ; Mon, 7 Aug 2017 14:52:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 97671242134; Mon, 7 Aug 2017 07:52:45 -0700 (PDT) Date: Mon, 7 Aug 2017 07:52:45 -0700 From: "Michael Blow (Code Review)" Message-ID: Reply-To: mblow@apache.org X-Gerrit-MessageType: newchange Subject: Change in asterixdb[master]: [NO ISSUE][HYR][FAIL][RT] Avoid wrapping Errors X-Gerrit-Change-Id: I7bb47c036a58ac9d8cb2dc77391a17dd22df19ad X-Gerrit-ChangeURL: X-Gerrit-Commit: 90bd74cd227a4080c551c321891e2167c4360dec MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 To: undisclosed-recipients:; archived-at: Mon, 07 Aug 2017 14:52:53 -0000 Michael Blow has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1922 Change subject: [NO ISSUE][HYR][FAIL][RT] Avoid wrapping Errors ...................................................................... [NO ISSUE][HYR][FAIL][RT] Avoid wrapping Errors Change-Id: I7bb47c036a58ac9d8cb2dc77391a17dd22df19ad --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/22/1922/1 diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java index 0a99ea6..2cf804e 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java @@ -36,8 +36,10 @@ public static HyracksDataException create(Throwable cause) { if (cause instanceof HyracksDataException || cause == null) { return (HyracksDataException) cause; - } - if (cause instanceof InterruptedException && !Thread.currentThread().isInterrupted()) { + } else if (cause instanceof Error) { + // don't wrap errors, allow them to propagate + throw (Error)cause; + } else if (cause instanceof InterruptedException && !Thread.currentThread().isInterrupted()) { LOGGER.log(Level.WARNING, "Wrapping an InterruptedException in HyracksDataException and current thread is not interrupted", cause); -- To view, visit https://asterix-gerrit.ics.uci.edu/1922 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7bb47c036a58ac9d8cb2dc77391a17dd22df19ad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow