From user-return-1262-archive-asf-public=cust-asf.ponee.io@arrow.apache.org  Tue Jun  8 12:32:34 2021
Return-Path: <user-return-1262-archive-asf-public=cust-asf.ponee.io@arrow.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255])
	by mx-eu-01.ponee.io (Postfix) with ESMTPS id 1D4D718060E
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  8 Jun 2021 14:32:34 +0200 (CEST)
Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153])
	by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 4934340364
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  8 Jun 2021 12:32:33 +0000 (UTC)
Received: (qmail 89144 invoked by uid 500); 8 Jun 2021 12:32:32 -0000
Mailing-List: contact user-help@arrow.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:user-help@arrow.apache.org>
List-Unsubscribe: <mailto:user-unsubscribe@arrow.apache.org>
List-Post: <mailto:user@arrow.apache.org>
List-Id: <user.arrow.apache.org>
Reply-To: user@arrow.apache.org
Delivered-To: mailing list user@arrow.apache.org
Received: (qmail 89134 invoked by uid 99); 8 Jun 2021 12:32:32 -0000
Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jun 2021 12:32:32 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id 5CB6BC0484
	for <user@arrow.apache.org>; Tue,  8 Jun 2021 12:32:31 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.2
X-Spam-Level:
X-Spam-Status: No, score=0.2 tagged_above=-999 required=6.31
	tests=[HTML_MESSAGE=0.2, SPF_PASS=-0.001, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-ec2-va.apache.org ([116.203.227.195])
	by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024)
	with ESMTP id rkQymEufja95 for <user@arrow.apache.org>;
	Tue,  8 Jun 2021 12:32:30 +0000 (UTC)
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=34.238.96.61; helo=mail2.evoforge.org; envelope-from=efweber@evoforge.org; receiver=<UNKNOWN> 
Received: from mail2.evoforge.org (mail2.evoforge.org [34.238.96.61])
	by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 2AE73BD232
	for <user@arrow.apache.org>; Tue,  8 Jun 2021 12:32:30 +0000 (UTC)
Received: from webmail.evoforge.org (webmail.evoforge.org [10.110.1.99]) by mail2.evoforge.org with ESMTP id UdDRtncdceRTig3S (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <user@arrow.apache.org>; Tue, 08 Jun 2021 08:32:23 -0400 (EDT)
Received: from is-exchdb-02.evoforge.org (10.110.1.99) by
 is-exchdb-02.evoforge.org (10.110.1.99) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2176.14; Tue, 8 Jun 2021 12:32:23 +0000
Received: from is-exchdb-02.evoforge.org ([fe80::e5bd:eaa7:3146:6bc0]) by
 is-exchdb-02.evoforge.org ([fe80::e5bd:eaa7:3146:6bc0%5]) with mapi id
 15.01.2176.014; Tue, 8 Jun 2021 12:32:23 +0000
From: "Weber, Eugene" <efweber@evoforge.org>
To: "user@arrow.apache.org" <user@arrow.apache.org>
Subject: C++ ARROW_DEPRECATED Use MemoryPool-less variant
Thread-Topic: C++ ARROW_DEPRECATED Use MemoryPool-less variant
Thread-Index: AQHXXF69aN8PwmXDfUKO8PvO8q2cLg==
Date: Tue, 8 Jun 2021 12:32:23 +0000
Message-ID: <fff351245fb744fbaa548606ba82a4ec@evoforge.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.112.2.38]
Content-Type: multipart/alternative;
	boundary="_000_fff351245fb744fbaa548606ba82a4ecevoforgeorg_"
MIME-Version: 1.0
X-Virus-Scanned: by bsmtpd at evoforge.org

--_000_fff351245fb744fbaa548606ba82a4ecevoforgeorg_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi,


When I compile example.cc under cpp/examples/minimal_build I get a deprecia=
tion warning on:


      arrow::csv::TableReader::Make(arrow::default_memory_pool(),
                                    arrow::io::default_io_context(),
                                    input_file,
                                    arrow::csv::ReadOptions::Defaults(),
                                    arrow::csv::ParseOptions::Defaults(),
                                    arrow::csv::ConvertOptions::Defaults())=
);


The deprecation code in reader.h is:


  ARROW_DEPRECATED("Use MemoryPool-less variant (the IOContext holds a pool=
 already)")
  static Result<std::shared_ptr<TableReader>> Make(
      MemoryPool* pool, io::IOContext io_context, std::shared_ptr<io::Input=
Stream> input,
      const ReadOptions&, const ParseOptions&, const ConvertOptions&);


I've read the documentation on MemoryPool, but I'm still not fully understa=
nding the relationship between TableReader and MemoryPool, or how exactly t=
o correct the example code. I understand that the CVS table is read into a =
table structure in memory allocated from the memory pool. I'm not understan=
ding the meaning of "Use MemoryPool-less variant (the IOContext holds a poo=
l already)".


Thanks in advance for the clarification.


Gene

--_000_fff351245fb744fbaa548606ba82a4ecevoforgeorg_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"><!-- P {margin-top:0;margi=
n-bottom:0;} --></style>
</head>
<body dir=3D"ltr">
<div id=3D"divtagdefaultwrapper" dir=3D"ltr" style=3D"font-size: 12pt; colo=
r: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, &q=
uot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, NotoColorEmoji, &q=
uot;Segoe UI Symbol&quot;, &quot;Android Emoji&quot;, EmojiSymbols;">
<p>Hi,</p>
<p><br>
</p>
<p>When I compile&nbsp;<span>example.cc under cpp/examples/<span>minimal_bu=
ild I get a depreciation&nbsp;warning on:&nbsp;</span></span></p>
<p><span><span><br>
</span></span></p>
<p><span><span></span></span></p>
<div>&nbsp; &nbsp; &nbsp; arrow::csv::TableReader::Make(arrow::default_memo=
ry_pool(),</div>
<div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; arrow::io::default_=
io_context(),</div>
<div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; input_file,</div>
<div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; arrow::csv::ReadOpt=
ions::Defaults(),</div>
<div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; arrow::csv::ParseOp=
tions::Defaults(),</div>
<div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; arrow::csv::Convert=
Options::Defaults()));</div>
<br>
<p></p>
<p><span><span>The deprecation code in reader.h is:</span></span></p>
<p><span><span><br>
</span></span></p>
<p><span><span></span></span></p>
<div>&nbsp; ARROW_DEPRECATED(&quot;Use MemoryPool-less variant (the IOConte=
xt holds a pool already)&quot;)</div>
<div>&nbsp; static Result&lt;std::shared_ptr&lt;TableReader&gt;&gt; Make(</=
div>
<div>&nbsp; &nbsp; &nbsp; MemoryPool* pool, io::IOContext io_context, std::=
shared_ptr&lt;io::InputStream&gt; input,</div>
<div>&nbsp; &nbsp; &nbsp; const ReadOptions&amp;, const ParseOptions&amp;, =
const ConvertOptions&amp;);</div>
<br>
<p></p>
<p><span><span>I've read the documentation on MemoryPool, but I'm&nbsp;stil=
l not fully&nbsp;understanding the relationship between TableReader and Mem=
oryPool, or how exactly to correct the example code. I understand that the =
CVS table is read into a table structure in
 memory allocated from the memory pool. I'm not understanding the meaning o=
f&nbsp;<span style=3D"font-family:Calibri,Helvetica,sans-serif,EmojiFont,&q=
uot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;,NotoColorEmoji,&quot=
;Segoe UI Symbol&quot;,&quot;Android Emoji&quot;,EmojiSymbols; font-size:16=
px">&quot;Use
 MemoryPool-less variant (the IOContext holds a pool already)&quot;.&nbsp;<=
/span></span></span></p>
<p><span><span><span style=3D"font-family:Calibri,Helvetica,sans-serif,Emoj=
iFont,&quot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;,NotoColorEmo=
ji,&quot;Segoe UI Symbol&quot;,&quot;Android Emoji&quot;,EmojiSymbols; font=
-size:16px"><br>
</span></span></span></p>
<p><span><span><span style=3D"font-family:Calibri,Helvetica,sans-serif,Emoj=
iFont,&quot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;,NotoColorEmo=
ji,&quot;Segoe UI Symbol&quot;,&quot;Android Emoji&quot;,EmojiSymbols; font=
-size:16px">Thanks in advance for the clarification.</span></span></span></=
p>
<p><span><span><span style=3D"font-family:Calibri,Helvetica,sans-serif,Emoj=
iFont,&quot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;,NotoColorEmo=
ji,&quot;Segoe UI Symbol&quot;,&quot;Android Emoji&quot;,EmojiSymbols; font=
-size:16px"><br>
</span></span></span></p>
<p><span><span><span style=3D"font-family:Calibri,Helvetica,sans-serif,Emoj=
iFont,&quot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;,NotoColorEmo=
ji,&quot;Segoe UI Symbol&quot;,&quot;Android Emoji&quot;,EmojiSymbols; font=
-size:16px">Gene&nbsp;</span></span></span></p>
</div>
</body>
</html>

--_000_fff351245fb744fbaa548606ba82a4ecevoforgeorg_--