From user-return-1280-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Thu Jun 24 14:46:43 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 7E99D180648 for ; Thu, 24 Jun 2021 16:46:43 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id BEB80435DD for ; Thu, 24 Jun 2021 14:46:41 +0000 (UTC) Received: (qmail 67470 invoked by uid 500); 24 Jun 2021 14:46:40 -0000 Mailing-List: contact user-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@arrow.apache.org Delivered-To: mailing list user@arrow.apache.org Received: (qmail 67460 invoked by uid 99); 24 Jun 2021 14:46:40 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jun 2021 14:46:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id E2D93C03D8 for ; Thu, 24 Jun 2021 14:46:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-fi.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id IG2RYJqNTZSF for ; Thu, 24 Jun 2021 14:46:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::12f; helo=mail-lf1-x12f.google.com; envelope-from=wesmckinn@gmail.com; receiver= Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 55E7D7FFEE for ; Thu, 24 Jun 2021 14:46:38 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id x24so10669541lfr.10 for ; Thu, 24 Jun 2021 07:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=40QFRMJkFFgcKrR4/yHP5nZ1DRHDN5XbMcKdw8DE6P4=; b=AQk5b4GjrVdatwfFjEGmQJOL5EyR8CYE5ffgUA4b1eagrXpZWnfTFzo92dNFObtM5l NEbNa4WKygXq1pfTn8Luol3em1Xf1k1Do4AFDl/tgECvlvlNuqWiuITt+ab9sB3xTNf4 xo0GA8Fa0DSgWnsaVZFE4EEOycfKWGzpdn8OctXJdJ4EVeRM09bYwtEaStqKoC+u+UdP pEg+kzM7X2JXJOHw0HLQMd4IFYKX7ab0X2FZlMeL+qmejn0tV02fyMbdU8TCf3VNMZYd 1eljSd1Vh4PZI6bZc3pjrJKumSeyPFEGY1EHeNrkJ8pHHF0iln9ebrNKrG7vvzCV8E5x E/vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=40QFRMJkFFgcKrR4/yHP5nZ1DRHDN5XbMcKdw8DE6P4=; b=TPk9YbITJ/kFf7515ZoFrzbMdKKAH8EFS1kCzSjBdLRtEHoPbDB37a8yzNV9MejPb1 Ctz4peV7Se2FysspvR4eWecN3lDtp++qL79opaewHYP4aI5yu7S9NeIPryCUoNKbcK3L HCO41vmXUjsbrcdmAYlZqGwmD57fiFbqSDaeef32dtT2ceJ7hYrB9pI25j6mlzYets8B TBxu5mS+l3h+Bgq+UTbwrT9t1DDA4foVRtJhtmM67AHFnTWI7Fk9ykNz2fPe//mwJ37I 2oTLW5l8XYFXnjv8qXubDKRz/yvgawPZNohjATFYiFiwuSEA/RkxwcwF5nzAhUlwI8c9 g/ug== X-Gm-Message-State: AOAM530l6h0QK/slJzpkpEniaCxoLKoGzXFS5SnkhN46dNY44YznwJ0f iJfw2pMJmfFWPrgO2wuGJZ23iWoUqoQTNGWeVyw/egIVkm0= X-Google-Smtp-Source: ABdhPJzBPWcUxCvGVBBaq51LxyKha+sYoWkferC6NBOl6iwjqxfuuUt8imQc9oSX26NQri6PqO5vkJPtbMfvUwjucfw= X-Received: by 2002:a19:6d06:: with SMTP id i6mr4031914lfc.223.1624545997342; Thu, 24 Jun 2021 07:46:37 -0700 (PDT) MIME-Version: 1.0 References: <62ba0a47a6ba49aa92cc5d2328d127cd@evoforge.org> In-Reply-To: <62ba0a47a6ba49aa92cc5d2328d127cd@evoforge.org> From: Wes McKinney Date: Thu, 24 Jun 2021 09:46:01 -0500 Message-ID: Subject: Re: LLVM Question To: user@arrow.apache.org Content-Type: multipart/alternative; boundary="00000000000017d09205c58417bf" --00000000000017d09205c58417bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable clang-format is only used in development for formatting the codebase (and checking that it's been formatted). Clang tools (format and tidy) aren't necessary for building the library (Gandiva) that requires LLVM On Thu, Jun 24, 2021 at 9:43 AM Weber, Eugene wrote: > Hi, > > > I'm running Centos 7. In the Arrow C++ build documentation it states that > you are using LLVM 8. I can install llvm-toolset-7.0 which contains > llvm/clang version 7.0.1. To get a more recent version of llvm on Centos = 7 > it would need to be built from source. I tried to do this a few times > following various online "recipes", but failed. Not the clearest/simplest > process I've seen. =F0=9F=98=89 I decided to just give version 7.0.1 a tr= y. > > > Attached is my build script and build log. It appears to build > successfully, but it does give these messages: > > -- clang-tidy not found > > -- clang-format not found > > -- Could NOT find ClangTools (missing: CLANG_FORMAT_BIN CLANG_TIDY_BIN) > > > I tried adding the following to my build script: > > export CLANG_TIDY_BIN=3D/opt/rh/llvm-toolset-7/root/usr/bin > > export CLANG_FORMAT_BIN=3D/opt/rh/llvm-toolset-7.0/root/usr/bin > > export PATH=3D/opt/rh/llvm-toolset-7/root/usr/bin:$PATH > > But the messages remain. > > When I run unit tests, all 71 tests pass. So at this point there doesn't > appear to be any issue using llvm/clang 7.0.1. > > Are the "not found" messages OK? > Is it OK to use llvm/clang 7.0.1? > > Thanks, > > Gene > > > > > --00000000000017d09205c58417bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
clang-format is only used in development for formatting the codeb= ase (and checking that it's been formatted). Clang tools (format and ti= dy) aren't necessary for building the library (Gandiva) that requires L= LVM

On Thu, Jun 24, 2021 at 9:43 AM Weber, Eugene <efweber@evoforge.org> wrote:

Hi,


I'm running Centos 7. In the Arrow=C2=A0C++ build documentation it s= tates that you are=C2=A0using LLVM 8. I can install=C2=A0llvm-t= oolset-7.0 which contains llvm/clang version 7.0.1. To get a more recent ve= rsion of llvm on Centos 7 it would need to be built from source. I tried to do this a few times following various online=C2=A0= "recipes", but failed. Not the clearest/simplest process I've= seen. =F0=9F=98=89 I decided to just give version 7.0.1 a try.=C2=A0=


Attached is my build script and build log. It appears to bui= ld successfully, but it does give these messages:

-- clang-tidy not found

-- clang-format not found

-- Could NOT find ClangTools (missing: CLANG_FORMAT_BIN CLANG_TIDY_BIN= )


I tried adding the following to my build script:=C2=A0

export CLANG_TIDY_BIN=3D/opt/rh/llvm-toolset-7/root/usr/bin

export CLANG_FORMAT_BIN=3D/opt/rh/llvm-toolset-7.0/root/usr/bin

export PATH=3D/opt/rh/llvm-toolset-7/root/usr/bin:$PATH

But = the messages remain.

When I run unit tests, all 71 tests pass. So at this point=C2=A0there = doesn't appear to be any issue using llvm/clang 7.0.1.=C2=A0

Are the "not found" messages OK?
Is it OK to use llvm/clang 7.0.1?

Thanks,

Gene




--00000000000017d09205c58417bf--