From dev-return-6237-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Wed Apr 4 20:29:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3119F18064F for ; Wed, 4 Apr 2018 20:29:08 +0200 (CEST) Received: (qmail 22288 invoked by uid 500); 4 Apr 2018 18:29:02 -0000 Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list dev@arrow.apache.org Received: (qmail 22277 invoked by uid 99); 4 Apr 2018 18:29:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 18:29:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 887C4C6928 for ; Wed, 4 Apr 2018 18:29:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id FOf-FgNaNv80 for ; Wed, 4 Apr 2018 18:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C948C5F1F0 for ; Wed, 4 Apr 2018 18:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5411DE00D6 for ; Wed, 4 Apr 2018 18:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 21C4B25611 for ; Wed, 4 Apr 2018 18:29:00 +0000 (UTC) Date: Wed, 4 Apr 2018 18:29:00 +0000 (UTC) From: "dennis lucero (JIRA)" To: dev@arrow.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ARROW-2393) [C++] arrow/status.h does not define ARROW_CHECK needed for ARROW_CHECK_OK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 dennis lucero created ARROW-2393: ------------------------------------ Summary: [C++] arrow/status.h does not define ARROW_CHECK needed for ARROW_CHECK_OK Key: ARROW-2393 URL: https://issues.apache.org/jira/browse/ARROW-2393 Project: Apache Arrow Issue Type: Bug Components: C++ Affects Versions: 0.9.0 Reporter: dennis lucero test.cpp {code:c++} #include int main(void) { arrow::Int64Builder i64builder; std::shared_ptr i64array; ARROW_CHECK_OK(i64builder.Finish(&i64array)); return EXIT_SUCCESS; } {code} Attempt to build: {code:bash} $CXX test.cpp -std=c++11 -larrow {code} Error: {code} test.cpp:6:2: error: use of undeclared identifier 'ARROW_CHECK' ARROW_CHECK_OK(i64builder.Finish(&i64array)); ^ xxx/include/arrow/status.h:49:27: note: expanded from macro 'ARROW_CHECK_OK' #define ARROW_CHECK_OK(s) ARROW_CHECK_OK_PREPEND(s, "Bad status") ^ xxx/include/arrow/status.h:44:5: note: expanded from macro 'ARROW_CHECK_OK_PREPEND' ARROW_CHECK(_s.ok()) << (msg) << ": " << _s.ToString(); \ ^ 1 error generated. {code} I expect that ARROW_* macro are public API, and should work out of the box. A naive attempt to fix it {code} diff --git a/cpp/src/arrow/status.h b/cpp/src/arrow/status.h index 84f55e41..6da4a773 100644 --- a/cpp/src/arrow/status.h +++ b/cpp/src/arrow/status.h @@ -25,6 +25,7 @@ #include "arrow/util/macros.h" #include "arrow/util/visibility.h" +#include "arrow/util/logging.h" // Return the given status if it is not OK. #define ARROW_RETURN_NOT_OK(s) \ {code} fails with {code} public-api-test.cc:21:2: error: "DCHECK should not be visible from Arrow public headers." {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)