arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Pitrou (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-2400) [C++] Status destructor is expensive
Date Thu, 05 Apr 2018 10:46:00 GMT
Antoine Pitrou created ARROW-2400:
-------------------------------------

             Summary: [C++] Status destructor is expensive
                 Key: ARROW-2400
                 URL: https://issues.apache.org/jira/browse/ARROW-2400
             Project: Apache Arrow
          Issue Type: Improvement
    Affects Versions: 0.9.0
            Reporter: Antoine Pitrou


Let's take the following micro-benchmark (in Python):

{code:bash}
$ python -m timeit -s "import pyarrow as pa; data = [b'xx' for i in range(10000)]" "pa.array(data,
type=pa.binary())"
1000 loops, best of 3: 784 usec per loop
{code}

If I replace the Status destructor with a no-op:
{code:c++}
  ~Status() { }
{code}

then the benchmark result becomes:
{code:bash}
$ python -m timeit -s "import pyarrow as pa; data = [b'xx' for i in range(10000)]" "pa.array(data,
type=pa.binary())"
1000 loops, best of 3: 561 usec per loop
{code}

This is almost a 30% win. I get similar results on the conversion benchmarks in the benchmark
suite.

I'm unsure about the explanation. In the common case, {{delete _state}} should be extremely
fast, since the state is NULL. Yet, it seems it adds significant overhead. Perhaps because
of exception handling?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message