arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Cutler (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-2380) Correct issues in numpy_to_arrow conversion routines
Date Mon, 02 Apr 2018 21:17:00 GMT
Bryan Cutler created ARROW-2380:
-----------------------------------

             Summary: Correct issues in numpy_to_arrow conversion routines
                 Key: ARROW-2380
                 URL: https://issues.apache.org/jira/browse/ARROW-2380
             Project: Apache Arrow
          Issue Type: Bug
          Components: Python
    Affects Versions: 0.9.0
            Reporter: Bryan Cutler
             Fix For: 0.10.0


Following the discussion at [https://github.com/apache/arrow/pull/1689,] there are a few issues
with conversion of various types to arrow that are incorrect or could be improved:
 * PyBytes_GET_SIZE is being casted to the wrong type, for example 
{{const int32_t length = static_cast<int32_t>(PyBytes_GET_SIZE(obj));}}

 * Handle the possibility with the statement
{{builder->value_data_length() + length > kBinaryMemoryLimit}}
if length is larger than kBinaryMemoryLimit

 * Look into using common code for binary object conversion to avoid duplication, and allow
support for bytes and bytearray objects in other places than numpy_to_arrow.  (possibly put
in src/arrow/python/helpers.h)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message