Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 51008 invoked by uid 500); 5 Sep 2001 04:53:06 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 50997 invoked from network); 5 Sep 2001 04:53:06 -0000 Date: Tue, 4 Sep 2001 21:52:46 -0700 From: Justin Erenkrantz To: dev@httpd.apache.org Cc: dev@apr.apache.org Subject: Re: Fw: Regarding lower-case HTML tags Message-ID: <20010904215246.Y10838@ebuilt.com> References: <047401c135b8$d39eaa50$93c0b0d0@roweclan.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <047401c135b8$d39eaa50$93c0b0d0@roweclan.net>; from wrowe@rowe-clan.net on Tue, Sep 04, 2001 at 10:12:32PM -0500 X-AntiVirus: scanned for viruses by AMaViS 0.2.1-pre3 (http://amavis.org/) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, Sep 04, 2001 at 10:12:32PM -0500, William A. Rowe, Jr. wrote: > Josh just came up with what I believe is the best explanation of if and > when to reformat - I think this applies equally well to sources and docs. > > I'd added only one caviat - changes to the format should always -preceed- > the patch to the actual code, and there shouldn't be format changes if there > is no work to commit that the existing format didn't interfere with. > > Note that +/- whitespace patches (including newlines) are _simple_ to ignore. > Changes to anything else (capitalization, etc) are most definately not. > > I personally reformat often - but only if it 1. increases legibility in > 2. a module I'm actively refactoring. But Joshes' explanation is great :) I'm wondering if we can add this on the site somewhere so that future committers don't end up in the same trap I found myself in. (There is no place anywhere that says that we don't actively follow the style guide...I was under the (false) impression that we should be actively following it...) -- justin