apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: apr/threadproc/win32 proc.c signals.c
Date Sun, 09 Sep 2001 06:22:44 GMT
> wrowe       01/09/08 23:03:05
>   Modified:    .        CHANGES
>                file_io/netware filesys.c
>                file_io/os2 filesys.c
>                file_io/unix filepath.c
>                file_io/win32 filepath.c filesys.c
>                include  apr_file_info.h apr_thread_proc.h
>                include/arch/os2 fileio.h
>                include/arch/win32 fileio.h threadproc.h
>                test     testmmap.c
>                threadproc/win32 proc.c signals.c
>   Log:
>     Fix the apr_proc_create for win32.  In order to do so, this patch
>     introduces a flags arg for apr_filepath_get(), like apr_filepath_merge(),
>     that allows the APR_FILEPATH_NATIVE result format.
>     This launches win32 processes with the Unicode semantics (although it
>     runs sbcs apps equally well) and changes the default to 'not detached',
>     in sync with the unix default.
>     Finally, assures apr_filepath_get() uses the '/' semantics on OS2 by
>     default.


This patch breaks all except .exe cgi's for win32, since we are passing multiple
arguments via the run_cgi_child call's command argument, instead of properly
filling in argv.  Since that's a bug, I've gone ahead and committed proper code
for win32's apr functions, and I'll go back to deal with the cgi issue tommorow.

Ryan pointed out that you can't pass multiple args for 'command'.  This turns
out to be probably untrue.  _But_ suexec won't handle them, so it's probably
safest to do this 'the proper way', always.


View raw message