From dev-return-67750-archive-asf-public=cust-asf.ponee.io@activemq.apache.org  Wed Oct 24 02:29:21 2018
Return-Path: <dev-return-67750-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 163D518066B
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 24 Oct 2018 02:29:20 +0200 (CEST)
Received: (qmail 43462 invoked by uid 500); 24 Oct 2018 00:29:20 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 43451 invoked by uid 99); 24 Oct 2018 00:29:19 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Oct 2018 00:29:19 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 4D4A2DFB32; Wed, 24 Oct 2018 00:29:19 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-2376-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-2376-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Content-Type: text/plain
Message-Id: <20181024002919.4D4A2DFB32@git1-us-west.apache.org>
Date: Wed, 24 Oct 2018 00:29:19 +0000 (UTC)

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609451
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java ---
    @@ -51,10 +51,14 @@ public JsonObjectBuilder toJson(RemotingConnection connection) {
     
           List<ServerSession> sessions = server.getSessions(connection.getID().toString());
           Set<String> users = new HashSet<>();
    +      String clientID = null;
     
           for (ServerSession session : sessions) {
              String username = session.getUsername() == null ? "" : session.getUsername();
              users.add(username);
    +         if (clientID == null) {
    +            clientID = session.getMetaData("jms-client-id") == null ? connection.getClientID() : session.getMetaData("jms-client-id");
    --- End diff --
    
    should avoid jms specifics such as this.
    



---