Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 1 Jul 2016 19:02:10 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12986034.1467336717000.7552.1467399730974@Atlassian.JIRA>
In-Reply-To: <JIRA.12986034.1467336717000@Atlassian.JIRA>
References: <JIRA.12986034.1467336717000@Atlassian.JIRA> <JIRA.12986034.1467336717426@arcas>
Subject: [jira] [Commented] (ACCUMULO-4357) Remove redundant code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 01 Jul 2016 19:02:13 -0000


    [ https://issues.apache.org/jira/browse/ACCUMULO-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359484#comment-15359484 ] 

Christopher Tubbs commented on ACCUMULO-4357:
---------------------------------------------

I was curious and had a few extra moments to spare, so I went into Eclipse and turned on some extra compiler warnings. I know the diamond operator was something we had discussed doing when we bumped to Java 7, but I also saw the other two things, which were relatively minor. Eclipse made it easy to take care of them automatically, so it was a pretty low-risk change using that built-in tooling.

There were others I chose not to apply, like removing unnecessary "else" clauses (such as when the previous "if" did a return, exit, or threw an exception). It helped readability in most cases, but it was a big change, and didn't help readability in all cases, so I chose not to apply it because I didn't have time to review and assess.

Another one I turned on was to look for unnecessary casts, but was surprised to find I didn't see any.

> Remove redundant code
> ---------------------
>
>                 Key: ACCUMULO-4357
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4357
>             Project: Accumulo
>          Issue Type: Task
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Trivial
>             Fix For: 1.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Minor QC nits quickly and easily fixed:
> * Remove unnecessary generics parameters; prefer diamond operator wherever possible.
> * Remove extra semicolons.
> * Remove redundant interface declarations.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)