Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Thu, 13 Aug 2015 17:46:45 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12855680.1439413430000.58792.1439488005921@Atlassian.JIRA>
In-Reply-To: <JIRA.12855680.1439413430000@Atlassian.JIRA>
References: <JIRA.12855680.1439413430000@Atlassian.JIRA>
 <JIRA.12855680.1439413430619@arcas>
Subject: [jira] [Commented] (ACCUMULO-3961) Filters should be able to skip
 data that they know will fail
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695642#comment-14695642 ] 

ASF GitHub Bot commented on ACCUMULO-3961:
------------------------------------------

GitHub user rweeks opened a pull request:

    https://github.com/apache/accumulo/pull/42

    Implementation of SeekingFilter, CfCqSliceFilter and CfCqSliceSeekingFilter

    OK let's try this again. Right bug id this time.
    
    Implementation for ACCUMULO-3961 including a filter which behaves similarly to the existing ColumnSliceFilter but can seek to the next potential match instead of explicitly rejecting every KV pair that falls outside the slice. Probably faster for small slices on large rows.
    
    Christopher switched the fix version to 1.8, I guess because adding new functionality should go into a minor release. So I'm targeting this against the master branch, because it doesn't look like a 1.8 branch exists yet.
    
    I know you guys require this to be rebased into a single commit. Is that something I can do on my side (I'm concerned about rebasing after I've pushed this to a public repo) or is that something you can do when you receive the pull request?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phemisystems/accumulo ACCUMULO-3961

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit a0c8d588109e2d8d0b3bdf862ec1d3e1e48c50e7
Author: Russ Weeks <rweeks@phemi.com>
Date:   2015-07-23T03:53:01Z

    Initial commit of CfCqSlice code. Renamed files but Java class names are messed up.

commit 9cc2c28251d445c86d7006bf1237ea2fd096b4e1
Author: Russ Weeks <rweeks@newbrightidea.com>
Date:   2015-07-23T04:23:12Z

    Removing cyclic dependency on MiniAccumuloCluster by moving tests to test module

commit 1100ba49ee09c97aadbe80429f54a13519a98552
Author: Russ Weeks <rweeks@newbrightidea.com>
Date:   2015-07-23T05:48:12Z

    Reformatted and added comment to SeekingFilter

commit e5ea222fa07ab8bb7211a12c87aa127146874f81
Author: Russ Weeks <rweeks@phemi.com>
Date:   2015-07-24T00:20:08Z

    Slice tests passing

commit f579acc4e60b7aa5cf36c59fad51ea36347204f0
Author: Russ Weeks <rweeks@phemi.com>
Date:   2015-08-13T17:21:31Z

    Added class-level javadoc, fixed problem with OptionsDescriber

commit dc2655622f71676012cf849a849e2e89fd936d26
Author: Russ Weeks <rweeks@phemi.com>
Date:   2015-08-13T17:44:38Z

    tweaking the javadoc.

----


> Filters should be able to skip data that they know will fail
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-3961
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3961
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.7.0
>            Reporter: Russ Weeks
>            Assignee: Russ Weeks
>            Priority: Minor
>              Labels: filter, iterator
>             Fix For: 1.8.0
>
>
> A [filter|http://accumulo.apache.org/1.7/apidocs/org/apache/accumulo/core/iterators/Filter.html] should be able to cause its source to advance past key/value pairs that it knows will be blocked by the filter. For example, the [ColumnSliceFilter|http://accumulo.apache.org/1.7/apidocs/index.html?org/apache/accumulo/core/iterators/user/ColumnSliceFilter.html] should be able to advance to the beginning of the slice in the next row, if it has detected that it has reached the end of the slice in the current row.
> Inspired by HBase's [FilterBase|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/FilterBase.html] and [ColumnRangeFilter|https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/ColumnRangeFilter.html].


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)