Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8B9918BD7 for ; Thu, 13 Aug 2015 23:21:45 +0000 (UTC) Received: (qmail 88915 invoked by uid 500); 13 Aug 2015 23:21:45 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 88867 invoked by uid 500); 13 Aug 2015 23:21:45 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 88850 invoked by uid 99); 13 Aug 2015 23:21:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 23:21:45 +0000 Date: Thu, 13 Aug 2015 23:21:45 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ACCUMULO-3956) Improve validation of configuration and arguments with guava Predicates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs resolved ACCUMULO-3956. ----------------------------------------- Resolution: Fixed > Improve validation of configuration and arguments with guava Predicates > ----------------------------------------------------------------------- > > Key: ACCUMULO-3956 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3956 > Project: Accumulo > Issue Type: Improvement > Reporter: Christopher Tubbs > Assignee: Christopher Tubbs > Fix For: 1.8.0 > > Time Spent: 10m > Remaining Estimate: 0h > > There's a few places in our code which could benefit from additional validation of arguments and configuration by using the built-in Guava Predicates. This makes some checks that we're doing a bit more readable, and enables us to do more expressive validation checks. > Specifically, I see room for improvement in our {{PropertyType}} validators (which currently do very limited regex validation) and, to a lesser degree, {{o.a.a.core.util.Validator}}. > I intend to replace these with proper Predicates to determine their validity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)