Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB9DE1080D for ; Wed, 2 Apr 2014 14:43:18 +0000 (UTC) Received: (qmail 45645 invoked by uid 500); 2 Apr 2014 14:43:16 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 45609 invoked by uid 500); 2 Apr 2014 14:43:15 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 45589 invoked by uid 99); 2 Apr 2014 14:43:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 14:43:15 +0000 Date: Wed, 2 Apr 2014 14:43:15 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ACCUMULO-2229) Make init.d scripts get into the assembly in a more maveny way MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs resolved ACCUMULO-2229. ----------------------------------------- Resolution: Won't Fix Superceded by ACCUMULO-2606 > Make init.d scripts get into the assembly in a more maveny way > -------------------------------------------------------------- > > Key: ACCUMULO-2229 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2229 > Project: Accumulo > Issue Type: Improvement > Components: build > Affects Versions: 1.6.0 > Reporter: Michael Berman > Priority: Minor > > (forked from ACCUMULO-1983) > For 1.6 the init.d scripts were moved into the module for the corresponding service rather than all being piled into the assemble module. To get them into the assembly, the scripts are just copied by path out of assemble's siblings. This is simple and it's easy to see what's going on when looking at the pom, but it definitely violates maven best practices (don't reference ".."). I think if we want to keep the init.d scripts with their corresponding modules, the maveny way to do it would be to declare the init.d script as an artifact of each module (of type "init.d" or something), and then declare them as dependencies of the packager, which could then use the copy-dependencies goal to get them into the assembly. It's more lines of pom and possibly more opaque as far as figuring out where each file is coming from, but it would be more portable and less sensitive to module rearrangements in the future. > Is this a good idea? Is it pom overkill? -- This message was sent by Atlassian JIRA (v6.2#6252)