Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: ZooKeeper clients does not handle new error codes properly
From: Flavio Junqueira <fpj@apache.org>
In-Reply-To: <954962C10920654BBE157862C7272BA540FB134A@szxeml561-mbx.china.huawei.com>
Date: Mon, 3 Oct 2016 11:05:47 +0100
Cc: "user@zookeeper.apache.org" <user@zookeeper.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <178974D4-5557-4946-A804-D6818BD98A7B@apache.org>
References: <954962C10920654BBE157862C7272BA540FB134A@szxeml561-mbx.china.huawei.com>
To: dev@zookeeper.apache.org
archived-at: Mon, 03 Oct 2016 10:06:08 -0000

Hi Arshad,

It makes sense to me. What if we convert unknown server errors to =
KeeperException.SystemErrorException? This is a generic error and it =
extends KeeperException.

I don't see it as a big issue to make this change, but others may feel =
differently. If we do it, then we will need a release note pointing out =
the change of behavior.

-Flavio

> On 03 Oct 2016, at 08:54, Mohammad arshad <mohammad.arshad@huawei.com> =
wrote:
>=20
> Hi All,
> In Zookeeper rolling upgrade scenario where server is new but client =
is old, when sever sends error code which is not understood by a client, =
 client throws IllegalArgumentException. Generally =
IllegalArgumentException is not handled by any of the ZK applications. =
It is too generic. How to handle this scenario in ZK applications?
> My understanding is instead of throwing IllegalArgumentException we =
should throw a subclass of KeeperException, for example =
InvalidErrorCodeException, so that zk apps can take more specific =
action.
> Any thoughts?
>=20
> Thanks
> -Arshad
>=20