zookeeper-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Shraer <shra...@gmail.com>
Subject Re: Is myid actually limited to [1, 255]?
Date Mon, 13 Jul 2015 18:43:13 GMT
negative ids could break stuff, such as here:

https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L321

On Mon, Jul 13, 2015 at 11:07 AM, Raúl Gutiérrez Segalés <
rgs@itevenworks.net> wrote:

> Hi,
>
> On 13 July 2015 at 10:43, Benjamin Anderson <b@banjiewen.net> wrote:
>
> > Hi there - I've observed that the documentation[1] suggests that each
> > node's myid should be an integer in the range [1, 255]. Is that
> > limitation codified anywhere? A quick perusal of the source suggests
> > that myid is parsed in to a Long and passed around as such through the
> > codebase.
> >
> > For context, I'm working on automating a ZK deployment and having a
> > larger range for myid values would make my life easier.
> >
>
> Yeah, definitely wrong (I've used 0, -1, ..). Mind opening a JIRA to get it
> fixed (a patch would be
> most welcomed too!). Otherwise I'll get to it a bit later. Thanks!
>
>
> -rgs
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message