Mailing-List: contact user-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@zookeeper.apache.org
Subject: Re: using utf-8 encoding on java files
MIME-Version: 1.0
From: Chris Nauroth <cnauroth@hortonworks.com>
To: "user@zookeeper.apache.org" <user@zookeeper.apache.org>,
	"dev@zookeeper.apache.org" <dev@zookeeper.apache.org>
Thread-Topic: using utf-8 encoding on java files
Thread-Index: AQHQm7zmP1W0uA7B20e+tE+oohIy0J2W0qaAgAAXnID//5lugA==
Date: Sun, 31 May 2015 20:08:41 +0000
Message-ID: <D190B7CB.23892%cnauroth@hortonworks.com>
References: 
 <CAMUR=WhzdemDrgDd0aocRQRx8HpRknxuaPhx+bU23hqq9BLGZA@mail.gmail.com>
 <CAHYqJpFb2TEc1r9-vBP7y9-RHW_tF7FYih4rVENePTuMZSYYTg@mail.gmail.com>
 <CAMUR=WiHUp3o0QrdfKc53VFm4MYMOH3MBhFtBdFJq0oZbgDOTA@mail.gmail.com>
In-Reply-To: 
 <CAMUR=WiHUp3o0QrdfKc53VFm4MYMOH3MBhFtBdFJq0oZbgDOTA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C66CF9F9F18058478B3C8C716980EBF5@exch080.serverpod.net>
Content-Transfer-Encoding: quoted-printable

Another small benefit of UTF-8 source encoding is that we can write test
cases for passing around multi-byte characters without having to use the
"\u0000"-style escaping syntax.

--Chris Nauroth


On 5/31/15, 12:15 PM, "Ra=FAl Guti=E9rrez Segal=E9s" <rgs@itevenworks.net> =
wrote:

>On 31 May 2015 at 10:51, Michi Mutsuzaki <mutsuzaki@gmail.com> wrote:
>
>> It sounds fine to me, but any reason why we shouldn't stick to ascii?
>>
>
>No strong reasons tbh, just the fact that utf-8 is sometimes useful for
>comments and it's
>probably becoming (if not already) the norm, etc.
>
>
>-rgs
>
>
>
>> On Sun, May 31, 2015 at 9:14 AM, Ra=FAl Guti=E9rrez Segal=E9s
>> <rgs@itevenworks.net> wrote:
>> > Heya,
>> >
>> > So in this issue:
>> >
>> > https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>> >
>> > we ran into a problem with utf-8 chars. How what about we teach javac
>>to
>> > treat
>> > all files as utf-8? Would that be a problem for anyone/any platform?
>> > Something like
>> > this in build.xml:
>> >
>> > <target name=3D"compile" depends=3D"ivy-retrieve,clover,build-generate=
d">
>> >         <javac srcdir=3D"${java.src.dir}" destdir=3D"${build.classes}"
>> > includeantruntime=3D"false"
>> >                target=3D"${javac.target}" source=3D"${javac.source}"
>> debug=3D"on"
>> > encoding=3D"UTF-8">
>> >             <classpath refid=3D"java.classpath"/>
>> >             <compilerarg value=3D"-Xlint:all"/>
>> >             <compilerarg value=3D"-Xlint:-path"/>
>> >         </javac>
>> > </target>
>> >
>> > Thoughts?
>> >
>> >
>> > -rgs
>>