zookeeper-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michi Mutsuzaki <mutsuz...@gmail.com>
Subject Re: using utf-8 encoding on java files
Date Sun, 31 May 2015 21:02:22 GMT
Sounds good. I'll update the patch to use utf8 consistently across all
the javac invocations.

On Sun, May 31, 2015 at 1:08 PM, Chris Nauroth <cnauroth@hortonworks.com> wrote:
> Another small benefit of UTF-8 source encoding is that we can write test
> cases for passing around multi-byte characters without having to use the
> "\u0000"-style escaping syntax.
>
> --Chris Nauroth
>
>
>
>
> On 5/31/15, 12:15 PM, "Raúl Gutiérrez Segalés" <rgs@itevenworks.net> wrote:
>
>>On 31 May 2015 at 10:51, Michi Mutsuzaki <mutsuzaki@gmail.com> wrote:
>>
>>> It sounds fine to me, but any reason why we shouldn't stick to ascii?
>>>
>>
>>No strong reasons tbh, just the fact that utf-8 is sometimes useful for
>>comments and it's
>>probably becoming (if not already) the norm, etc.
>>
>>
>>-rgs
>>
>>
>>
>>> On Sun, May 31, 2015 at 9:14 AM, Raúl Gutiérrez Segalés
>>> <rgs@itevenworks.net> wrote:
>>> > Heya,
>>> >
>>> > So in this issue:
>>> >
>>> > https://issues.apache.org/jira/browse/ZOOKEEPER-2197
>>> >
>>> > we ran into a problem with utf-8 chars. How what about we teach javac
>>>to
>>> > treat
>>> > all files as utf-8? Would that be a problem for anyone/any platform?
>>> > Something like
>>> > this in build.xml:
>>> >
>>> > <target name="compile" depends="ivy-retrieve,clover,build-generated">
>>> >         <javac srcdir="${java.src.dir}" destdir="${build.classes}"
>>> > includeantruntime="false"
>>> >                target="${javac.target}" source="${javac.source}"
>>> debug="on"
>>> > encoding="UTF-8">
>>> >             <classpath refid="java.classpath"/>
>>> >             <compilerarg value="-Xlint:all"/>
>>> >             <compilerarg value="-Xlint:-path"/>
>>> >         </javac>
>>> > </target>
>>> >
>>> > Thoughts?
>>> >
>>> >
>>> > -rgs
>>>
>

Mime
View raw message