zookeeper-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mahadev Konar <maha...@yahoo-inc.com>
Subject Re: Instantiating HashSet for DataNode?
Date Tue, 14 Jul 2009 20:50:11 GMT
Hi Erik,
  I am not sure if that would a considerable opitmization but even if you
wanted to do it, it would be much more than just adding a check in the
constructor (the serialization/deserialization would need to have
specialized code). Right now all the datanodes are treated equally for
ser/derser and other purposes.


mahadev




On 7/14/09 1:42 PM, "Erik Holstad" <erikholstad@gmail.com> wrote:

> I'm not sure if I've miss read the code for the DataNode, but to me it looks
> like every node gets a set of children even though it might be an
> ephemeral node which cannot have children, so we are wasting 240 B for every
> one of those. Not sure if it makes a big difference, but just thinking
> that since everything sits in memory and there is no reason to instantiate
> it, maybe it would be possible just to add a check in the constructor?
> 
> Regards Erik


Mime
View raw message