zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] shahrs87 opened a new pull request #1755: ZOOKEEPER-4367 Zookeeper#Login thread leak in case of Sasl AuthFailed.
Date Tue, 14 Sep 2021 20:27:08 GMT

shahrs87 opened a new pull request #1755:
URL: https://github.com/apache/zookeeper/pull/1755


   https://issues.apache.org/jira/browse/ZOOKEEPER-4367
   
   Things changed in this PR:
   1. Moving `zooKeeperSaslClient` from `ClientCnxn` to `SendThread` since only SendThread
is creating and accessing `zooKeeperSaslClient`
   2. Moved closing of `zooKeeperSaslClient` from `ClientCnxn#disconnect` method to `SendThread#run`
method. This will make sure that we will close zooKeeperSaslClient (and in turn close Login
object) even if `ClientCnxn#disconnect` is not called which happens when we encounter AuthFailed
Exceptions. Also it looks clean that whenever SendThread is terminating we clean up all the
class variable.
   3. Setting login to null when `ZooKeeperSaslClient#shutdown` is called. This helps me testing
whether zooKeeperSaslClient object is shutdown and in turn Login object is shutdown.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message