From notifications-return-7261-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Oct 15 07:06:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A0C34180654 for ; Thu, 15 Oct 2020 09:06:09 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 1FFD46513C for ; Thu, 15 Oct 2020 07:06:09 +0000 (UTC) Received: (qmail 74434 invoked by uid 500); 15 Oct 2020 07:06:08 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 74425 invoked by uid 99); 15 Oct 2020 07:06:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2020 07:06:08 +0000 From: =?utf-8?q?GitBox?= To: notifications@zookeeper.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bzookeeper=5D_eolivelli_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=231503=3A_ZOOKEEPER-3959=3A_Add_support_for_multiple_?= =?utf-8?q?SASL-authenticated_super_users?= Message-ID: <160274556832.32230.8075455947454264332.asfpy@gitbox.apache.org> Date: Thu, 15 Oct 2020 07:06:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: eolivelli commented on a change in pull request #1503: URL: https://github.com/apache/zookeeper/pull/1503#discussion_r505238251 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -1627,6 +1628,22 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer) throws IOE } } + private static boolean isSaslSuperUser(String id) { + String superUser = System.getProperty(SASL_SUPER_USER); + + if (superUser == null || id == null || id.isEmpty()) { + return false; + } + + for (String superId : superUser.split(",")) { Review comment: In order to be 100% compatible....what about using a list of properties - zookeeper.superUser=foo - zookeeper.superUser.1=foo2 - zookeeper.superUser.2=foo3 - zookeeper.superUser.3=foo4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org