zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1503: ZOOKEEPER-3959: Add support for multiple SASL-authenticated super users
Date Thu, 15 Oct 2020 07:06:08 GMT

eolivelli commented on a change in pull request #1503:
URL: https://github.com/apache/zookeeper/pull/1503#discussion_r505238251



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1627,6 +1628,22 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer)
throws IOE
         }
     }
 
+    private static boolean isSaslSuperUser(String id) {
+        String superUser = System.getProperty(SASL_SUPER_USER);
+
+        if (superUser == null || id == null || id.isEmpty()) {
+            return false;
+        }
+
+        for (String superId : superUser.split(",")) {

Review comment:
       In order to be 100% compatible....what about using a list of properties 
   - zookeeper.superUser=foo
   - zookeeper.superUser.1=foo2
   - zookeeper.superUser.2=foo3
   - zookeeper.superUser.3=foo4
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message